Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: hint Aila as to which part of the lesson to update next #265

Merged
merged 2 commits into from
Oct 24, 2024

Conversation

stefl
Copy link
Contributor

@stefl stefl commented Oct 24, 2024

Description

We've had several issues to do with the prompt that this address:

  • Automatically picking a lesson for basedOn
  • Not completing all sections in a section group
  • Doing a whole interaction when picking a basedOn rather than starting the lesson once the choice has been made
  • Incorrectly using basedOn logic when there is no content
  • Not having any guidelines for some sections
  • Language being too lengthy
  • Responses not relating to the actually-generated sections

This addresses several of these issues and fixes a bug whereby the with-RAG workflow was kicking in even though there were no relevant lessons.

Includes HB's recent prompt changes for the missing sections and updates the body with her PR.

Copy link

vercel bot commented Oct 24, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
oak-ai-lesson-assistant ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 24, 2024 11:54am

Copy link

Copy link

Playwright test results

passed  13 passed
skipped  1 skipped

Details

report  Open report ↗︎
stats  14 tests across 13 suites
duration  1 minute, 34 seconds
commit  a6df270

Skipped tests

No persona › tests/auth.test.ts › authenticate through Clerk UI

Copy link
Collaborator

@codeincontext codeincontext left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code here looks good 👍

The prompt changes are a bit too extensive to unpick in detail, and I'm not sure which changes are you vs HB

We should definitely get @mikeritson-oak to test these prompt changes ahead of merging - though if they've already been tested in the PR this is pulled from then we're good to go!

@stefl
Copy link
Contributor Author

stefl commented Oct 24, 2024

The code here looks good 👍

The prompt changes are a bit too extensive to unpick in detail, and I'm not sure which changes are you vs HB

We should definitely get @mikeritson-oak to test these prompt changes ahead of merging - though if they've already been tested in the PR this is pulled from then we're good to go!

Yep - these are the prompt changes that we've QAed on the main PR

@stefl stefl merged commit b8b39b8 into main Oct 24, 2024
14 checks passed
@stefl stefl deleted the feat/prompt_progress branch October 24, 2024 12:43
@oak-machine-user
Copy link
Collaborator

🎉 This PR is included in version 1.12.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants