fix: reduce turbo errors on local dev, enable running e2e in built mode #259
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Playwright test results
Details
Skipped testsNo persona › tests/auth.test.ts › authenticate through Clerk UI |
|
| "dev-turbo": "pnpm with-env node scripts/increase-listeners.js next dev --port 2525 --turbo | pino-pretty -C", | ||
| "dev-server": "pnpm with-env node scripts/increase-listeners.js next dev --port 2525 | pino-pretty -C", | ||
| "dev": "FORCE_COLOR=1 concurrently \"pnpm dev-server\" \"node scripts/local-dev.mjs\"", | ||
| "dev-turbo": "FORCE_COLOR=1 concurrently \"pnpm dev-server-turbo\" \"node scripts/local-dev.mjs\"", |
There was a problem hiding this comment.
For my benefit, what tool needs FORCE_COLOR? Is it because concurrently is getting in the way? Could you add it to .env like DEBUG_COLORS?
I'm not convinced that we actually need the concurrent local dev server any more. I haven't noticed any issues having it disabled in the last week
There was a problem hiding this comment.
We could probably remove it now, yes. Turbo seems to be so much better that I am no longer running it.
| module.exports = withSentryConfig(module.exports, { | ||
| // For all available options, see: | ||
| // https://github.com/getsentry/sentry-webpack-plugin#options | ||
| if (!process.env.TURBOPACK) { |
There was a problem hiding this comment.
I can see that there's a benefit for not having the monitoring instrumentation in here. But what if we need to test sentry locally?
There was a problem hiding this comment.
In that case, running the server in non-turbo dev mode would let you test it
There was a problem hiding this comment.
The benefit is just to try to remove the sentry / turbo incompatibility
There was a problem hiding this comment.
I think that we should only have the turbo mode as default, to be honest
|
🎉 This PR is included in version 1.12.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Description
Incremental improvements to try to reduce turbo errors and test timeouts.
Turbo mode:
Running the e2e server in built mode could mean that: