Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: findLast is not available for all browsers (WIP) #211

Merged
merged 2 commits into from
Oct 14, 2024
Merged

fix: findLast is not available for all browsers (WIP) #211

merged 2 commits into from
Oct 14, 2024

Conversation

stefl
Copy link
Contributor

@stefl stefl commented Oct 10, 2024

Description

  • Fixes an issue where some browsers do not have findLast because it's a relatively new JS method

Issue(s)

Fixes 9006645

@vercel Vercel
Copy link

vercel bot commented Oct 10, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
oak-ai-lesson-assistant ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 11, 2024 9:38am

@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 10, 2024 •
edited
Loading

Playwright e2e tests

Job summary

Download report

To view traces locally, unzip the report and run:

npx playwright show-report ~/Downloads/playwright-report

codeincontext
codeincontext approved these changes Oct 10, 2024
View reviewed changes
Copy link
Collaborator

@codeincontext codeincontext left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I looked into this. I was expecting our tsconfig to be polyfilling findLast, and couldn't work out why it wasn't. I think this is the right thing to do

@stefl stefl changed the title fix: findLast is not available for all browsers fix: findLast is not available for all browsers (WIP) Oct 11, 2024
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@stefl stefl merged commit a94e0f4 into main Oct 14, 2024
11 checks passed
@stefl stefl deleted the fix/findlast branch October 14, 2024 11:09
@codeincontext codeincontext mentioned this pull request Oct 15, 2024
Merged
@oak-machine-user
Copy link
Collaborator

🎉 This PR is included in version 1.10.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mantagen mantagen mantagen approved these changes

@codeincontext codeincontext codeincontext approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@stefl @oak-machine-user @codeincontext @mantagen