Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: refetch chat on mount to fix the blank chat issue on back navigation #166

Merged
merged 5 commits into from
Sep 30, 2024

Conversation

stefl
Copy link
Contributor

@stefl stefl commented Sep 27, 2024

Description

  • Addresses an issue where the chat is blank when navigating back from the downloads page

How to test

  1. Create a complete chat
  2. Go to the download page
  3. Press the back to lesson link at the top left
  4. See that the chat has loaded

Copy link

vercel bot commented Sep 27, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
oak-ai-lesson-assistant ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 27, 2024 9:49am

Copy link

github-actions bot commented Sep 27, 2024

Playwright e2e tests

Job summary

Download report

To view traces locally, unzip the report and run:

npx playwright show-report ~/Downloads/playwright-report

@stefl stefl changed the title fix: refetch chat on mount to fix the blank chat issue on back navigation fix: refetch chat on mount to fix the blank chat issue on back navigation (WIP) Sep 27, 2024
@stefl stefl changed the title fix: refetch chat on mount to fix the blank chat issue on back navigation (WIP) fix: refetch chat on mount to fix the blank chat issue on back navigation Sep 27, 2024
Copy link

// return newLessonPlan ?? workingLessonPlan;
// },
// [isStreaming],
// );

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shall we delete commented out code while we arnt using it?

@stefl stefl merged commit c2f74d7 into main Sep 30, 2024
15 checks passed
@stefl stefl deleted the fix/back_blank branch September 30, 2024 07:38
@oak-machine-user
Copy link
Collaborator

🎉 This PR is included in version 1.9.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants