-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: message ids, flag and modify tables #145
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Playwright e2e testsTo view traces locally, unzip the report and run: npx playwright show-report ~/Downloads/playwright-report |
@@ -0,0 +1,124 @@ | |||
import * as Sentry from "@sentry/nextjs"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly moves the file into its own router
|
||
if (vercelUrl?.includes("production")) { | ||
return "labs.thenational.academy"; | ||
if (vercelEnv === "production") { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Realised this was still returning a preview URL before
userId String @map("user_id") | ||
chatId String @map("chat_id") | ||
messageId String @map("message_id") | ||
textForMod String? @map("text_for_mod") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Made this nullable, will remove in a subsequent migration, as it's not storing meaningful data
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why not just remove now?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cause if i remove it before the code changes are in ... then someone will flag something, it will try to add textForMod
and it will fail.
This way the migrations and the code don't have to go in at theexact saem time
Quality Gate failedFailed conditions |
ALTER TABLE "aila_user_modifications" ADD COLUMN "action_other_text" TEXT, | ||
ADD COLUMN "section_path" TEXT, | ||
ADD COLUMN "section_value" JSONB, | ||
ALTER COLUMN "text_for_mod" DROP NOT NULL; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚨 run migrations stg reminder
🎉 This PR is included in version 1.8.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Description