fix: return protocol error messages for user restrictions #111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
codeincontext
force-pushed
the
fix/rate-limit-response
branch
3 times, most recently
from
a794c5e to
90a4964
Compare
Playwright e2e testsTo view traces locally, unzip the report and run: npx playwright show-report ~/Downloads/playwright-report |
codeincontext
force-pushed
the
fix/rate-limit-response
branch
from
1cb932d to
3eeda2f
Compare
codeincontext
force-pushed
the
fix/rate-limit-response
branch
from
d8c459c to
a717c6d
Compare
|
stefl
reviewed
Sep 10, 2024
| } | ||
|
|
||
| throw e; | ||
| } |
There was a problem hiding this comment.
Yeah! Much nicer to have it in one place
stefl
approved these changes
Sep 10, 2024
|
🎉 This PR is included in version 1.7.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
mantagen
pushed a commit
that referenced
this pull request
Oct 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Our streaming chat protocol allows us to send predefined error and action messages when a user is banned, rate limited, etc. With recent refactors we've lost some of that functionality
Changes:
failureMessagepattern in chat handler, and throw specific error instances insteadshouldPerformUserLookup,handleUserLookup,mockUserIdfunctionality as it was only used to support testsHow to test
Rate limiting
RATELIMIT_GENERATIONS_PER_24Hin dopplerAccount locking
mod:toxas the textScreenshots