Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Develop frontend image #35

Closed
giobart opened this issue Sep 21, 2023 · 2 comments · Fixed by #43
Closed

Develop frontend image #35

giobart opened this issue Sep 21, 2023 · 2 comments · Fixed by #43
Assignees
Labels
enhancement New feature or request priority/medium Priority medium tasks

Comments

@giobart
Copy link
Contributor

giobart commented Sep 21, 2023

Create a develop branch and add a GitHub workflow that builds develop FE images for testing purposes like this:

Create alpha tags
https://github.com/oakestra/oakestra/blob/develop/.github/workflows/create-alpha-tags.yml

This creates an alpha tag from a push in develop triggering the new build

@giobart giobart self-assigned this Sep 21, 2023
@giobart giobart added enhancement New feature or request priority/medium Priority medium tasks labels Sep 21, 2023
@giobart giobart assigned giobart and TFphoenix and unassigned giobart Nov 2, 2023
@oakestra oakestra deleted a comment from TFphoenix Nov 2, 2023
@TFphoenix
Copy link
Contributor

TFphoenix commented Nov 3, 2023

I had a few questions:

  • Is the version.txt file generated manually? And if yes, which initial version should I use for the dashboard project?
  • Should I also integrate the release-tags functionality? Or are we focusing on the alpha tags only at this moment?
  • I see the create-build.yml already exists, should I change its name, or modify it somehow, because it seems that this script already creates the required image, am I right?
  • Should I also implement the actual tests workflow? And if yes, what should it include? I'm imagining Karma UTs/configuration, anything else? (although it seems we don't have any tests currently for the dashboard)

@nitindermohan
Copy link
Contributor

@TFphoenix While @giobart answers your dev-related first three points, let me answer your last one.
Yes, automated tests for frontend workflow would be highly appreciated. Could you possibly open a new issue with test requirements in dashboard repo? That ways we can have a more in-depth discussion, with inputs from @danimair9 as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request priority/medium Priority medium tasks
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants