-
Notifications
You must be signed in to change notification settings - Fork 43
add compatibility version for hosted engine dc and cluster #375
add compatibility version for hosted engine dc and cluster #375
Conversation
Hello contributor, thanks for submitting a PR for this project! I am the bot who triggers "standard-CI" builds for this project. In order to allow automated tests to run, please ask one of the project maintainers to review the code and then do one of the following:
|
verified!! |
@arachmani @eslutsky could you please CR |
Isn't only ovirt-hosted-engine-setup interacting with this role? If so shouldn't this be exposed/fixed in the ovirt-hosted-engine-setup instead? |
It is also used when running the playbook directly. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
AFAIU, DC and cluster can be different versions, right?
If so let's use different vars and add the limitations to the README.
…er and for cluster
Btw hosted-engine-setup has already been moved to https://github.com/ovirt/ovirt-ansible-collection so we are going to archive this repository soon (or at least archive master), so I suggest to move this PR to oVirt Ansible Collection and start switching the automation to use the collection |
Created new PR in: @arachmani @mwperina |
merged in: |
AFAIU the latest versions (4.4.2, 4.4.3) should not support the ansible collections. |
On the contrary, from oVirt 4.4.3 are going to support only ansible 2.9.z with ovirt-ansible-collection, which will obsolete all oVirt modules in ansible core and all previously supported standalone oVirt roles. |
OK, we had an offline discussion and we need to help QE until they will switch automation to Ansible Collection. Asaf/Sandro, could you please merge this backport from collection here? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
thank you @mwperina @arachmani @sandrobonazzola |
in the latest version of 4.4, we have a new data center and cluster compatibility version - 4.5
by default, we use the latest data center and cluster compatibility version - 4.5
but we need also the option to define the hosted engine to stay with compatibility version 4.4