Skip to content
This repository has been archived by the owner on Feb 9, 2022. It is now read-only.

add compatibility version for hosted engine dc and cluster #375

Merged
merged 2 commits into from
Oct 12, 2020

Conversation

kobihk
Copy link
Contributor

@kobihk kobihk commented Sep 15, 2020

in the latest version of 4.4, we have a new data center and cluster compatibility version - 4.5
by default, we use the latest data center and cluster compatibility version - 4.5
but we need also the option to define the hosted engine to stay with compatibility version 4.4

@ovirt-infra
Copy link

Hello contributor, thanks for submitting a PR for this project!

I am the bot who triggers "standard-CI" builds for this project.
As a security measure, I will not run automated tests on PRs that are not from white-listed contributors.

In order to allow automated tests to run, please ask one of the project maintainers to review the code and then do one of the following:

  1. Type ci test please on this PR to trigger automated tests for it.
  2. Type ci add to whitelist on this PR to trigger automated tests for it and also add you to the contributor white-list so that your future PRs will be tested automatically. ( keep in mind this list might be overwritten if the job XML is refreshed, for permanent whitelisting, please follow Add generic test for service status #3 option )
  3. If you are planning to contribute to more than one project, maybe it's better to ask them to add you to the project organization, so you'll be able to run tests for all the organization's projects.

@kobihk
Copy link
Contributor Author

kobihk commented Sep 15, 2020

verified!!

@kobihk
Copy link
Contributor Author

kobihk commented Sep 15, 2020

@arachmani @eslutsky could you please CR

@mwperina
Copy link
Member

Isn't only ovirt-hosted-engine-setup interacting with this role? If so shouldn't this be exposed/fixed in the ovirt-hosted-engine-setup instead?

@arachmani
Copy link
Member

Isn't only ovirt-hosted-engine-setup interacting with this role? If so shouldn't this be exposed/fixed in the ovirt-hosted-engine-setup instead?

It is also used when running the playbook directly.

Copy link
Member

@arachmani arachmani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AFAIU, DC and cluster can be different versions, right?
If so let's use different vars and add the limitations to the README.

@mwperina
Copy link
Member

Btw hosted-engine-setup has already been moved to https://github.com/ovirt/ovirt-ansible-collection so we are going to archive this repository soon (or at least archive master), so I suggest to move this PR to oVirt Ansible Collection and start switching the automation to use the collection

@kobihk
Copy link
Contributor Author

kobihk commented Sep 21, 2020

Created new PR in:
oVirt/ovirt-ansible-collection#125

@arachmani @mwperina
maybe it will be better to add a deprecation comment as we have in:
https://github.com/oVirt/ovirt-ansible-repositories/pull/62/files

@kobihk
Copy link
Contributor Author

kobihk commented Sep 22, 2020

merged in:
oVirt/ovirt-ansible-collection#125

@kobihk kobihk closed this Sep 22, 2020
@kobihk
Copy link
Contributor Author

kobihk commented Oct 11, 2020

AFAIU the latest versions (4.4.2, 4.4.3) should not support the ansible collections.
so I think we still need to keep this repo updated.
@mwperina wdyt?

@kobihk kobihk reopened this Oct 11, 2020
@mwperina
Copy link
Member

AFAIU the latest versions (4.4.2, 4.4.3) should not support the ansible collections.
so I think we still need to keep this repo updated.
@mwperina wdyt?

On the contrary, from oVirt 4.4.3 are going to support only ansible 2.9.z with ovirt-ansible-collection, which will obsolete all oVirt modules in ansible core and all previously supported standalone oVirt roles.

@mwperina
Copy link
Member

OK, we had an offline discussion and we need to help QE until they will switch automation to Ansible Collection. Asaf/Sandro, could you please merge this backport from collection here?

@arachmani @sandrobonazzola

Copy link
Member

@mwperina mwperina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@arachmani arachmani merged commit 4630147 into oVirt:master Oct 12, 2020
@kobihk
Copy link
Contributor Author

kobihk commented Oct 12, 2020

thank you @mwperina @arachmani @sandrobonazzola

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants