Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLI Release 0.9.0 #426

Merged
merged 8 commits into from
Jun 6, 2023
Merged

CLI Release 0.9.0 #426

merged 8 commits into from
Jun 6, 2023

Conversation

ymekuria
Copy link
Collaborator

@ymekuria ymekuria commented Jun 6, 2023

Closes #425

This PR is the corresponding zkApp cli release to the SnarkyJS release of version 0.11.0.

  • SnarkyJS minor version dependency updated in cli package.json to 0.11.*.
  • SnarkyJS minor version peer dependency updated in template/example contract package.json to 0.11.*.
  • Replace deprecated Circuit.if with Provable.if in the tictactoe example.
  • Replace deprecated Circuit.array with Provable.Array in the sudoku example.

Tested

This was tested by generating projects with various cli flows. The template add contract, sudoku, and tictactoe examples were all successfully deployed.

@ymekuria ymekuria changed the title ZkApp CLI Release 0.9.0 CLI Release 0.9.0 Jun 6, 2023
@mitschabaude
Copy link
Contributor

@ymekuria I see that tic tac toe fails, it seems this is because it used Provable.if(b, x, y) where x and y are Optional<T> and the new Provable.if doesn't try to magically figure out a fields serialization of a type -- it needs type info.

I can push a fix!

@ymekuria
Copy link
Collaborator Author

ymekuria commented Jun 6, 2023

I see that tic tac toe fails, it seems this is because it used Provable.if(b, x, y) where x and y are Optional<T> and the new Provable.if doesn't try to magically figure out a fields serialization of a type -- it needs type info.

I can push a fix!

Thanks for the fix and the explanation! I was able to work around the build error by adding a toFields method to the Optional class but I wasn't sure if this was solving the root cause of the failure and didn't push the change.

@ymekuria ymekuria merged commit d49063b into main Jun 6, 2023
@ymekuria ymekuria deleted the release/0.9.0 branch June 6, 2023 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Release v 0.9.0
2 participants