Skip to content
This repository has been archived by the owner on Mar 6, 2019. It is now read-only.

Basic Pourover example broken #39

Closed
ngopal opened this issue Aug 26, 2014 · 2 comments
Closed

Basic Pourover example broken #39

ngopal opened this issue Aug 26, 2014 · 2 comments

Comments

@ngopal
Copy link

ngopal commented Aug 26, 2014

It looks like the basic pourover example found at this url is broken with the latest underscore.js (1.7.0) and pourover.js.

Specifically, adding filters to a collection:

collection.addFilters([mythology_filter, gender_filter, hobbies_filter]);

returns: "Uncaught TypeError: undefined is not a function"

Update: I was able to reproduce the error in both chrome and firefox.

@jdalton
Copy link
Contributor

jdalton commented Aug 27, 2014

The PR #14 would fix it. It's related to Underscore 1.7.0's breaking change to _.extend to iterate over own-properties only of source objects (aligns with Lo-Dash/ ES6 Object.assign).

@esmooov
Copy link
Contributor

esmooov commented Nov 25, 2014

Fixed!

@esmooov esmooov closed this as completed Nov 25, 2014
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants