Updates #64
Merged
Updates #64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tonglil
requested review from
a team,
msuterski,
sbower and
soeirosantos
and removed request for
a team
sbower
approved these changes
Apr 15, 2020
oliver-nyt
reviewed
Apr 16, 2020
msuterski
reviewed
Apr 16, 2020
| @@ -293,13 +293,13 @@ func configFromEnv(vargs *GAE, workspace *string) error { | |||
| func validateVargs(vargs *GAE) error { | |||
|
|
|||
| if vargs.Token == "" { | |||
| return fmt.Errorf("missing required param: token") | |||
| return fmt.Errorf("missing required credentials: GAE_CREDENTIALS or param token") | |||
There was a problem hiding this comment.
Is the plugin looking for a TOKEN or PLUGIN_TOKEN?
There was a problem hiding this comment.
No, this plugin is looking for GAE_CREDENTIALS. I know, it's not the same. Maybe future improvement can look for multiple but the way it is written now it doesn't.
There was a problem hiding this comment.
I was referring more to the error message where it says GAE_CREDENTIALS or param token
|
We can tag a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.