Adding hooks to use dispatch/cron yamls if referenced with deploy #57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oliver-nyt
approved these changes
Jul 29, 2019
sbower
reviewed
Jul 30, 2019
| case vargs.CronFile != "": | ||
| args = append(args, "./cron.yaml") | ||
| default: | ||
| args = append(args, "./app.yaml") |
There was a problem hiding this comment.
It seems like these are mutually exclusive, is that true? Could we just detect which file is present?
There was a problem hiding this comment.
@sbower all files may be present but the user can chose to use only some of them.
There was a problem hiding this comment.
I think folks could point the app_file config at a dispatch/cron file and the tool would use it, but it may be a bit confusing since the other two configs already exist.
There was a problem hiding this comment.
I've updated some docs to clarify
fsouza
approved these changes
Jul 30, 2019
oliver-nyt
reviewed
Jul 30, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Still need to verify it works, but looks to be a straightforward fix.