Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding "max_versions" feature to clean up older GAE versions post-deploy #47

Merged
merged 9 commits into from
Feb 20, 2019
Merged

Adding "max_versions" feature to clean up older GAE versions post-deploy #47

merged 9 commits into from
Feb 20, 2019

Conversation

jprobinson
Copy link
Contributor

Resolves #46

darrenmcc
darrenmcc reviewed Feb 20, 2019
View reviewed changes
remove.go Show resolved Hide resolved
darrenmcc
darrenmcc reviewed Feb 20, 2019
View reviewed changes
remove.go Outdated Show resolved Hide resolved
msuterski
msuterski reviewed Feb 20, 2019
View reviewed changes
remove.go Show resolved Hide resolved
darrenmcc
darrenmcc reviewed Feb 20, 2019
View reviewed changes
main.go Outdated Show resolved Hide resolved
msuterski
msuterski approved these changes Feb 20, 2019
View reviewed changes
Copy link
Contributor

@msuterski msuterski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

@jprobinson jprobinson merged commit dbf4282 into master Feb 20, 2019
@jprobinson jprobinson deleted the max_versions branch February 20, 2019 17:57
tonglil
tonglil reviewed Feb 20, 2019
View reviewed changes
Copy link
Member

@tonglil tonglil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tonglil tonglil tonglil left review comments

@darrenmcc darrenmcc darrenmcc left review comments

@msuterski msuterski msuterski approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jprobinson @msuterski @darrenmcc @tonglil