Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

php-base-prod/php-8.1-alpine for craft beta 4 ? #3

Closed
ezawadzki opened this issue Apr 5, 2022 · 2 comments
Closed

php-base-prod/php-8.1-alpine for craft beta 4 ? #3

ezawadzki opened this issue Apr 5, 2022 · 2 comments
Labels
enhancement New feature or request

Comments

@ezawadzki
Copy link

Hi,

Craft Beta 4 has been released.
php 8.1 is a requirements for installation.

Do you plan to create the docker image php-base-prod/php-8.1-alpine ?

I tried to change the base image and use :

FROM php:8.1-fpm-alpine3.14
or

FROM php:8.1-fpm-alpine3.15

In the aim to suggest a pull request. But got always this issue :

In file included from /usr/local/include/php/Zend/zend_config.h:1,
                 from /usr/local/include/php/Zend/zend_portability.h:43,
                 from /usr/local/include/php/Zend/zend_types.h:25,
                 from /usr/local/include/php/Zend/zend.h:27,
                 from /usr/local/include/php/main/php.h:31,
                 from /usr/src/php/ext/iconv/iconv.c:23:
/usr/local/include/php/main/../main/php_config.h:1802: warning: "ICONV_BROKEN_IGNORE" redefined
 1802 | #define ICONV_BROKEN_IGNORE 0
      | 
In file included from /usr/src/php/ext/iconv/iconv.c:20:
/usr/src/php/ext/iconv/config.h:56: note: this is the location of the previous definition
   56 | #define ICONV_BROKEN_IGNORE 1
      | 
/usr/src/php/ext/iconv/iconv.c: In function 'zm_startup_miconv':
/usr/src/php/ext/iconv/iconv.c:197:4: error: '_libiconv_version' undeclared (first use in this function)
  197 |    _libiconv_version >> 8, _libiconv_version & 0xff);
      |    ^~~~~~~~~~~~~~~~~
/usr/src/php/ext/iconv/iconv.c:197:4: note: each undeclared identifier is reported only once for each function it appears in
/usr/src/php/ext/iconv/iconv.c: In function '_php_iconv_appendl':
/usr/src/php/ext/iconv/iconv.c:97:15: warning: implicit declaration of function 'libiconv'; did you mean 'zif_iconv'? [-Wimplicit-function-declaration]
   97 | #define iconv libiconv
      |               ^~~~~~~~
/usr/src/php/ext/iconv/iconv.c:363:8: note: in expansion of macro 'iconv'
  363 |    if (iconv(cd, (char **)&in_p, &in_left, (char **) &out_p, &out_left) == (size_t)-1) {
      |        ^~~~~
make: *** [Makefile:205: iconv.lo] Error 1
The command '/bin/sh -c set -eux;     apk add --no-cache --virtual .build-deps         $PHPIZE_DEPS     &&     apk add --no-cache         bzip2-dev         ca-certificates         curl         fcgi         freetype-dev         gettext-dev         gnu-libiconv         icu-dev         imagemagick         imagemagick-dev         libjpeg-turbo-dev         libmcrypt-dev         libpng         libpng-dev         libressl-dev         libtool         libwebp-dev         libxml2-dev         libzip-dev         oniguruma-dev         unzip     &&     pecl install         redis     &&     mkdir -p /usr/src/php/ext/imagick     &&     curl -fsSL https://github.com/Imagick/imagick/archive/06116aa24b76edaf6b1693198f79e6c295eda8a9.tar.gz | tar xvz -C "/usr/src/php/ext/imagick" --strip 1     &&     docker-php-ext-configure         gd --enable-gd --with-freetype --with-jpeg --with-webp     &&     docker-php-ext-install         bcmath         bz2         exif         ftp         gettext         gd         iconv         intl         imagick         mbstring         opcache         pdo         shmop         sockets         sysvmsg         sysvsem         sysvshm         zip     &&     docker-php-ext-enable         imagick         redis     &&     apk del .build-deps     &&     rm -rf /tmp/* /var/tmp/*' returned a non-zero code: 2

I tried to pine gnu-libconv as suggested here. Got the same issue.

Cheers.

Emilie

@ezawadzki ezawadzki added the enhancement New feature or request label Apr 5, 2022
@khalwat
Copy link
Contributor

khalwat commented Apr 5, 2022

Craft CMS 4 does not require PHP 8.1 -- it requires PHP 8.0.2 or later, which these Docker images support. I'm using them with Craft 4 right now.

I will come out with PHP 8.1 Docker images soon too, however.

@khalwat khalwat closed this as completed Apr 5, 2022
@ezawadzki
Copy link
Author

Ah sorry ! I confused with minimum spec. So cool ! Thanks for quick answer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants