Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workbox precache-manifest does not pick up stylesheets #13

Open
ClemensSchneider opened this issue Mar 18, 2019 · 1 comment
Open

Workbox precache-manifest does not pick up stylesheets #13

ClemensSchneider opened this issue Mar 18, 2019 · 1 comment

Comments

@ClemensSchneider
Copy link

When building the project, the generated precache-manifest does only include javascript files but no stylesheets. This is due to the fact, that the workbox plugin is only included in the modern-build but stylesheets are only generated once for the legacy-build and thus are not available as assets in the modern-build.

Maybe it would be better to move stylesheets to the modern-build part so that they are visible to the "more relevant" modern-build parts?

@khalwat
Copy link
Contributor

khalwat commented Apr 15, 2019

So the logic here was that we don't want the SW to be running as part of the legacy build, because then it'll be pre-caching our old ES2015 JS... which is unlikely to be what we want if a SW is running.

So then perhaps we look into moving the CSS build into the modern build phase instead?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants