Bump sqlx to 0.7.4 #4959
Bump sqlx to 0.7.4 #4959
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 2 Skipped Deployments
|
dynco-nym
force-pushed
the
andrej/sqlx-0.7
branch
2 times, most recently
from
0717e69
to
367706b
Compare
There was a problem hiding this comment.
Reviewed 6 of 166 files at r1.
Reviewable status: 6 of 166 files reviewed, 1 unresolved discussion (waiting on @dynco-nym and @octol)
common/client-core/gateways-storage/.sqlx/query-0f1dfb89f1eb39f4a58787af0f53a7a93afb7e4d2e54e2d38fd79d31c8575a54.json line 3 at r1 (raw file):
{ "db_name": "SQLite", "query": "\n UPDATE remote_gateway_details\n SET\n derived_aes128_ctr_blake3_hmac_keys_bs58 = ?,\n derived_aes256_gcm_siv_key = ?\n WHERE gateway_id_bs58 = ?\n ",
This is an odd looking query. Is it supposed to be that way?
There was a problem hiding this comment.
Reviewed 160 of 166 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @octol)
nym-api/src/ecash/storage/manager.rs line 371 at r1 (raw file):
IssuedTicketbook, r#" SELECT
FYI I hope clearing this whitespace does not break the query
There was a problem hiding this comment.
Looks good to me, but also no sqlite expert ...
Reviewed all commit messages.
Reviewable status:
There was a problem hiding this comment.
Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @dynco-nym and @jstuczyn)
nym-api/src/support/storage/manager.rs line 556 at r1 (raw file):
Previously, dynco-nym (Dinko Zdravac) wrote…
The Executor impls for Transaction and PoolConnection have been deleted because they cannot exist in the new crate architecture without rewriting the Executor trait entirely.
To fix this breakage, simply add a dereference where an impl Executor is expected, as they both dereference to the inner connection type which will still implement it:mentioned here
I think .as_mut() is seemingly the same as &mut *tx
There was a problem hiding this comment.
Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @dynco-nym and @jstuczyn)
There was a problem hiding this comment.
Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @dynco-nym and @jstuczyn)
There was a problem hiding this comment.
Tested on macOS and Windows (ARM64). All cargo checks passed.
Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @dynco-nym and @jstuczyn)
There was a problem hiding this comment.
Reviewed 166 of 166 files at r1, all commit messages.
Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @dynco-nym)
More goodies Revert cargo.toml Fix cargo toml
Fix data-observatory Fix credential-storage Fix gateway-storage Fix client-core/-gateways-storage Generate offline schemas for nym-api as well
dynco-nym
force-pushed
the
andrej/sqlx-0.7
branch
from
367706b
to
65889dc
Compare
For sanity, please run all of these
This change is