Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(deps): bump toml from 0.5.11 to 0.8.14 #4805

Merged
merged 2 commits into from
Sep 19, 2024

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Aug 27, 2024

Bumps toml from 0.5.11 to 0.8.14.

Commits
  • c383efa chore: Release
  • 7bb1781 docs: Update changelog
  • 0af6deb Merge pull request #740 from epage/key-quotes
  • c9e36e7 fix(encode): Prefer literals over escaping double-quotes
  • 42f7a1b test(encode): Show existing quote behavior
  • 9e6290f chore(deps): Update compatible (dev) (#737)
  • dbf1cc1 Merge pull request #736 from epage/snapbox
  • ec9bfd7 chore: Update to snapbox 0.6
  • 881bf67 chore: Remove unused features
  • b62c76e refactor: Resolve deprecations
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

This change is Reviewable

@dependabot dependabot bot requested a review from octol as a code owner August 27, 2024 15:27
@dependabot dependabot bot added dependencies Pull requests that update a dependency file rust Pull requests that update Rust code labels Aug 27, 2024
Copy link

vercel bot commented Aug 27, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
nym-explorer ⬜️ Ignored (Inspect) Visit Preview Sep 16, 2024 9:03am
nym-next-explorer ⬜️ Ignored (Inspect) Visit Preview Sep 16, 2024 9:03am

Copy link
Contributor

@dynco-nym dynco-nym left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jstuczyn do we use this for reading/storing config anywhere? breaking config (de)serialization would be hard to spot, but a big problem

things like this being affected by this?

common/commands/Cargo.toml Outdated Show resolved Hide resolved
@dependabot dependabot bot force-pushed the dependabot/cargo/toml-0.8.14 branch from 8825f62 to dad569e Compare August 29, 2024 13:33
@jstuczyn
Copy link
Contributor

@jstuczyn do we use this for reading/storing config anywhere? breaking config (de)serialization would be hard to spot, but a big problem

things like this being affected by this?

good question. I'd perhaps hold on with merging this until we can do a sanity check first. last thing we'd want is all binaries breaking because we decided to upgrade this single dep

@jstuczyn jstuczyn added this to the Wedel milestone Aug 29, 2024
@dependabot dependabot bot force-pushed the dependabot/cargo/toml-0.8.14 branch from dad569e to 9b189ff Compare September 9, 2024 08:57
Copy link
Contributor Author

dependabot bot commented on behalf of github Sep 11, 2024

Dependabot encountered an unknown error. Because of this, Dependabot cannot update this pull request.

2 similar comments
Copy link
Contributor Author

dependabot bot commented on behalf of github Sep 11, 2024

Dependabot encountered an unknown error. Because of this, Dependabot cannot update this pull request.

Copy link
Contributor Author

dependabot bot commented on behalf of github Sep 11, 2024

Dependabot encountered an unknown error. Because of this, Dependabot cannot update this pull request.

@benedettadavico benedettadavico modified the milestones: Wedel, Aero Sep 11, 2024
Copy link
Contributor Author

dependabot bot commented on behalf of github Sep 11, 2024

Dependabot encountered an unknown error. Because of this, Dependabot cannot update this pull request.

1 similar comment
Copy link
Contributor Author

dependabot bot commented on behalf of github Sep 11, 2024

Dependabot encountered an unknown error. Because of this, Dependabot cannot update this pull request.

dependabot bot and others added 2 commits September 16, 2024 11:00
Bumps [toml](https://github.com/toml-rs/toml) from 0.5.11 to 0.8.14.
- [Commits](toml-rs/toml@toml-v0.5.11...toml-v0.8.14)

---
updated-dependencies:
- dependency-name: toml
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
@octol octol force-pushed the dependabot/cargo/toml-0.8.14 branch from 9b189ff to b6d16d5 Compare September 16, 2024 09:02
@octol octol self-assigned this Sep 19, 2024
@octol
Copy link
Contributor

octol commented Sep 19, 2024

@jstuczyn do we use this for reading/storing config anywhere? breaking config (de)serialization would be hard to spot, but a big problem
things like this being affected by this?

good question. I'd perhaps hold on with merging this until we can do a sanity check first. last thing we'd want is all binaries breaking because we decided to upgrade this single dep

I did some basic local smoke testing and reading config files still seem to work

@octol
Copy link
Contributor

octol commented Sep 19, 2024

For QA: this affects reading/writing config toml files for all binaries

@octol octol merged commit db55a96 into develop Sep 19, 2024
23 checks passed
@octol octol deleted the dependabot/cargo/toml-0.8.14 branch September 19, 2024 09:10
@benedettadavico
Copy link
Contributor

Testing Completion Date: [15/10/2024]

Testing Steps Performed:
Ensured that the cargo.toml is legible in various places; tested it on nym-node, nym-api and nymvisor.
Ensured that updating the cargo.toml file and restarting the given binary continues to behave as normal.

Validation:

  • Test Passed
  • Issues Found

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file rust Pull requests that update Rust code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants