Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Discussion: How should Spaces with no active logics look like in Edit mode? #100

Open
amycheng opened this issue Apr 17, 2018 · 0 comments
Labels
discussion real talk

Comments

@amycheng
Copy link
Contributor

Current Implementation: Let's say we have a Space with top stories components. One for articles tagged with "kitchen tools", another for those tagged with "shoes". If an article has the tag "kitchen tools", the Logic for the "kitchen tools" will have the active class and be visible in Edit mode. If the article doesn't have any of those tags, the "kitchen tools" top stories component will be active anyway. If there is no active logic for the page, clay-space-edit will designate the first logic in the Space to be active, which happens to be the "kitchen tools" Logic.

This is confusing for the user. There is no language in the UI that describes this behavior (and I don't think there should be, it would clutter the UI). I think this is why a rogue user has been deleting Space Logics from articles, leaving Spaces empty, and triggering errors.

Maybe we should have some placeholder text in lieu of any visible Logic, that says "This Space has no Active Logics". Users will still be able to edit Logic via the "Edit Space" button.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discussion real talk
Projects
None yet
Development

No branches or pull requests

1 participant