From d1bf796550f11c2d3854547453a719fb15c241bb Mon Sep 17 00:00:00 2001 From: Ayushman Chhabra <14110965+ayushmanchhabra@users.noreply.github.com> Date: Sat, 30 Nov 2024 14:56:21 +0530 Subject: [PATCH 1/7] chore(ci): switch from Windows 2022 to 2019 GitHub image runner --- .github/workflows/ci.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index a85b285..618dce4 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -16,7 +16,7 @@ jobs: os: - macos-14 - ubuntu-22.04 - # - windows-2022 + - windows-2019 fail-fast: false runs-on: ${{ matrix.os }} steps: From 37fc35ec4e44e50cfe055a7bce337f90c73834d4 Mon Sep 17 00:00:00 2001 From: Ayushman Chhabra <14110965+ayushmanchhabra@users.noreply.github.com> Date: Sat, 30 Nov 2024 14:57:55 +0530 Subject: [PATCH 2/7] chore(ci): upgrade MacOS and Windows runners to latest --- .github/workflows/ci.yml | 4 ++-- package.json | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 618dce4..b64f22d 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -14,8 +14,8 @@ jobs: strategy: matrix: os: - - macos-14 - - ubuntu-22.04 + - macos-15 + - ubuntu-24.04 - windows-2019 fail-fast: false runs-on: ${{ matrix.os }} diff --git a/package.json b/package.json index 6c64e97..b830af9 100644 --- a/package.json +++ b/package.json @@ -20,6 +20,6 @@ "test": "vitest run" }, "volta": { - "node": "21.1.0" + "node": "22.2.0" } } From f431df01825490c979b299357c88bef58634e469 Mon Sep 17 00:00:00 2001 From: Ayushman Chhabra <14110965+ayushmanchhabra@users.noreply.github.com> Date: Sat, 30 Nov 2024 16:21:46 +0530 Subject: [PATCH 3/7] chore(deps): update to latest --- package.json | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/package.json b/package.json index b830af9..db68843 100644 --- a/package.json +++ b/package.json @@ -3,7 +3,6 @@ "version": "1.0.0", "main": "index.html", "private": true, - "packageManager": "npm@10.5.0", "devDependencies": { "base-volta-off-of-nwjs": "^1.0.5", "node-gyp": "^10.2.0", @@ -20,6 +19,6 @@ "test": "vitest run" }, "volta": { - "node": "22.2.0" + "node": "22.7.0" } } From ddb902445e9c8c703250809620b75a474d665112 Mon Sep 17 00:00:00 2001 From: Ayushman Chhabra <14110965+ayushmanchhabra@users.noreply.github.com> Date: Sat, 30 Nov 2024 16:23:46 +0530 Subject: [PATCH 4/7] chore(ci): add node-gyp rebuild step in CI --- .github/workflows/ci.yml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index b64f22d..ae0f41f 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -30,5 +30,7 @@ jobs: run: npm -v - name: Install dependencies run: npm ci + -name: Rebuild Node addons + run: npm run gyp - name: Run selenium test suite run: npm t From cf23b31bd4be0c79e3d9d31de74530457ca48020 Mon Sep 17 00:00:00 2001 From: Ayushman Chhabra <14110965+ayushmanchhabra@users.noreply.github.com> Date: Sat, 30 Nov 2024 16:24:38 +0530 Subject: [PATCH 5/7] fix: use fs.promises.readFile to import Node manifest --- index.mjs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/index.mjs b/index.mjs index 62945d6..034c475 100644 --- a/index.mjs +++ b/index.mjs @@ -7,7 +7,7 @@ import process from "node:process"; import * as semver from "semver"; import * as tar from "tar"; -import nodeManifest from "./package.json" assert { type: "json"}; +const nodeManifest = JSON.parse(await fs.promises.readFile("./package.json")); const version = nodeManifest.devDependencies.nw.slice(1); const parsedVersion = semver.parse(version); From 009fe39d6ebb275cdf820932be63be02e5e93e00 Mon Sep 17 00:00:00 2001 From: Ayushman Chhabra <14110965+ayushmanchhabra@users.noreply.github.com> Date: Sat, 30 Nov 2024 16:26:57 +0530 Subject: [PATCH 6/7] fix(ci): resolvee synta eror --- .github/workflows/ci.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index ae0f41f..8786af2 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -30,7 +30,7 @@ jobs: run: npm -v - name: Install dependencies run: npm ci - -name: Rebuild Node addons + - name: Rebuild Node addons run: npm run gyp - name: Run selenium test suite run: npm t From 989dd7f0529febcbc0c3956966dece596af6dacc Mon Sep 17 00:00:00 2001 From: Ayushman Chhabra <14110965+ayushmanchhabra@users.noreply.github.com> Date: Sat, 30 Nov 2024 16:33:53 +0530 Subject: [PATCH 7/7] chore(ci): upgrade Windows runner to latest --- .github/workflows/ci.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 8786af2..7f96af2 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -16,7 +16,7 @@ jobs: os: - macos-15 - ubuntu-24.04 - - windows-2019 + - windows-2022 fail-fast: false runs-on: ${{ matrix.os }} steps: