Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Be smarter about available versions (& support alpha builds) #275

Closed
adam-lynch opened this issue Dec 6, 2015 · 3 comments
Closed

Be smarter about available versions (& support alpha builds) #275

adam-lynch opened this issue Dec 6, 2015 · 3 comments
Labels
bug Priority: 1 feature Priority: 2

Comments

@adam-lynch
Copy link
Contributor

Depends on nwjs/nw.js#4037.

This module would then get and validate versions a lot more solidly.

  • All versions would be grabbed reliably.
  • It would be a lot easier to avoid alpha builds when the version option is defaulted to latest.
  • Changes to the platform ZIPs between versions won't break anything.
  • People could use alpha builds if they like.
  • If the user tries to build for a version which doesn't support that platform, an error will be thrown.

Fixes #239, #253, #254, (probably) #255, #259, #262, and probably more.

@gaving
Copy link

gaving commented Dec 8, 2015

A big 👍 for this from somebody constantly working off alpha builds!

@jvkassi
Copy link

jvkassi commented May 1, 2016

update ? nwjs/nw.js#4037 is kinda fix now, right ?

@adam-lynch
Copy link
Contributor Author

Closed as of 2.2.1 (#337)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Priority: 1 feature Priority: 2
Projects
None yet
Development

No branches or pull requests

3 participants