NSHumanReadableCopyright shouldn't be mandatory

[adam-lynch]

I assume at least

[kentcdodds]

I'm getting this (may be the same issue)

Error: Missing macPlist property 'NSHumanReadableCopyright'
    at /Users/kentcdodds/dev/alianza/atac5/node_modules/node-webkit-builder/lib/utils.js:185:23
    at Array.forEach (native)
    at Object.module.exports.editPlist (/Users/kentcdodds/dev/alianza/atac5/node_modules/node-webkit-builder/lib/utils.js:183:11)
    at /Users/kentcdodds/dev/alianza/atac5/node_modules/node-webkit-builder/lib/index.js:503:32
    at /Users/kentcdodds/dev/alianza/atac5/node_modules/node-webkit-builder/lib/index.js:571:16
    at forOwn (/Users/kentcdodds/dev/alianza/atac5/node_modules/node-webkit-builder/node_modules/lodash/dist/lodash.js:2105:15)
    at Function.forEach (/Users/kentcdodds/dev/alianza/atac5/node_modules/node-webkit-builder/node_modules/lodash/dist/lodash.js:3302:9)
    at NwBuilder._forEachPlatform (/Users/kentcdodds/dev/alianza/atac5/node_modules/node-webkit-builder/lib/index.js:570:7)
    at NwBuilder.handleMacApp (/Users/kentcdodds/dev/alianza/atac5/node_modules/node-webkit-builder/lib/index.js:473:10)
    at tryCatch1 (/Users/kentcdodds/dev/alianza/atac5/node_modules/node-webkit-builder/node_modules/bluebird/js/main/util.js:63:19)

I was thinking this issue was coming from some dependency that node-webkit-builder had and not node-webkit-builder itself.

[adam-lynch]

@kentcdodds I know very little about Plist stuff but I'm hoping to fix this today. If you've any idea of what's wrong, let me know 😄

[kentcdodds]

I also know nothing about plist. But I took the plist in the repo and added the property NSHumanReadableCopyright with the value of 2014 and that seemed to fix this problem... Though I have another...

[kentcdodds]

Just in case you have the same problem, my error is:

fs.js:832
  return binding.chmod(pathModule._makeLong(path), modeNum(mode));
                 ^
Error: ENOENT, no such file or directory '/Users/kentcdodds/dev/alianza/atac5/standalone/Alianza Admin Portal/osx32/Alianza Admin Portal.app/Contents/Info.plist'
    at Object.fs.chmodSync (fs.js:832:18)
    at /Users/kentcdodds/dev/alianza/atac5/node_modules/node-webkit-builder/lib/utils.js:89:20
    at cb (/Users/kentcdodds/dev/alianza/atac5/node_modules/node-webkit-builder/node_modules/graceful-fs-extra/node_modules/fs-extra/node_modules/ncp/lib/ncp.js:260:37)
    at /Users/kentcdodds/dev/alianza/atac5/node_modules/node-webkit-builder/node_modules/graceful-fs-extra/node_modules/fs-extra/node_modules/ncp/lib/ncp.js:113:16
    at /Users/kentcdodds/dev/alianza/atac5/node_modules/node-webkit-builder/node_modules/graceful-fs-extra/node_modules/fs-extra/node_modules/ncp/lib/ncp.js:232:14
    at Object.oncomplete (fs.js:107:15)

[adam-lynch]

This might actually be to due to the copyFile problems I found in #142. Could you try npm install mllrsohn/node-webkit-builder#fixing-1.0.x and tell me if it still happens?

[bastimeyer]

It's because of f163a07... Let me fix this, I'll open a PR

[adam-lynch]

Ok @bastimeyer

[kentcdodds]

@adam-lynch, looks like it works I think. Though I'm getting this output for every file in my dist:

chmod 33188 on /Users/kentcdodds/dev/alianza/atac5/standalone/Alianza Admin Portal/osx32/Alianza Admin Portal.app/Contents/Resources/app.nw/favicon.ico failed after copying, ignoring

[adam-lynch]

Yeah, I added that log. I'm ignoring when an error occurs when chmod on a copied file fails. Not sure what to do. It might be useful to some people. I don't know.

[trevorah]

Fixed by 77c4383.