Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mac - Issue in app quit #3740

Open
siddhartha-gupta opened this issue Aug 7, 2015 · 9 comments
Open

Mac - Issue in app quit #3740

siddhartha-gupta opened this issue Aug 7, 2015 · 9 comments
Assignees

Comments

@siddhartha-gupta
Copy link

Hi,

I'm facing an issue in quitting Mac application, with following setup and steps

  • nw v0.12.3, with mac menu bar enabled with all options(edit, window etc)
  • Using grunt node webkit builder to package the app
  • Launch the app
  • minimize the app to doc
  • App menu is still visible and accessible
  • Try to quit the app by pressing 'cmd+q' or bu clicking 'quit' from menu
  • App is still running and in fact 'close' event is also not fired

Followed the steps mentioned in following issue but issue still persist - #430

Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

@jgoalby
Copy link

jgoalby commented Aug 7, 2015

Did you see this issue?
#3162

If you did, please comment on how the resolution/workaround didn't work for you. If you didn't see it, then I recommend searching the issues before creating a new issue.

If it is the same or very similar issue please consider closing this one.

@siddhartha-gupta
Copy link
Author

After binding the 'shortcut' key as mentioned in #3162 I was able to receive the quit event on app minimize, but the event is propagated to nw application even when keys are pressed for some other application. Basically, I want to receive the quit event when 'cmd+q' is pressed for nw app only, and not for other apps. Is there a way to distinguish this?

@siddhartha-gupta
Copy link
Author

Hi,

Can someone kindly provide an update/solution for the same :)

@jgoalby
Copy link

jgoalby commented Aug 14, 2015

I also see the same issue. It doesn't appear that #430 works any more in v12. Not sure if something changed. Doing CMD-TAB and CMD-Q on the icon works, but CMD-Q when in the dock doesn't work. Also clicking quit in the menu when in the dock doesn't work.

I put a console log in the win.on("close" ...) and see it when not in the dock just fine. Never see it when in dock except when CMD-TABing.

@siddhartha-gupta
Copy link
Author

Yup, it seems close event is not propagated to app in case app is not in focus.

@siddhartha-gupta
Copy link
Author

Any update?

@siddhartha-gupta
Copy link
Author

Just a gentle bump!

@sporsh
Copy link

sporsh commented Jun 9, 2016

Just tested this in v0.15.2, and it's still an issue. Would love to see a fix for this!

@Christywl
Copy link
Contributor

I can reproduce this issue on Mac with nwjs-sdk-v0.25.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants