Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue with Mac icon #106

Closed
jwoertink opened this issue Sep 4, 2014 · 5 comments
Closed

Issue with Mac icon #106

jwoertink opened this issue Sep 4, 2014 · 5 comments

Comments

@jwoertink
Copy link

When I build just the osx package, my icon shows up fine, but if I build both osx and win packages together, the win icon shows up fine, but the osx icon shows up as the default node-webkit icon. Here is my Gruntfile.js

module.exports = function(grunt) {
  grunt.initConfig({
    pkg: grunt.file.readJSON('package.json'),
    nodewebkit: {
      options: {
        version: '0.10.3',
        buildDir: './build',
        platforms: ['win', 'osx'],
        appName: 'ALICE Client',
        appVersion: '0.0.1',
        winIco: './webarc.nw/alice.ico',
        macIcns: './webarc.nw/alice.icns'
      },
      src: ['./webarc.nw/**']
    }
  });

  grunt.loadNpmTasks('grunt-node-webkit-builder');
  grunt.registerTask('default', ['nodewebkit']);
};

using version 0.2.2 on OSX 10.9.4
Is there something I'm missing?

@jwoertink
Copy link
Author

Ok, update to this. I stopped building the win package, and I noticed that randomly the mac icon will still show up as the default icon. If I just run grunt back to back a few times, my icon will eventually show up. Maybe a system cache that needs to be cleared each time?

@tphalp
Copy link

tphalp commented Oct 9, 2014

I'm experiencing the same thing, OSX 10.9.5, v0.2.3. App icon will only work part of the time. Sometimes it's just the default icon, and sometimes it's the one I have specified.

@jwoertink
Copy link
Author

I even got a new one today. Randomly two different times the icon was like the OSX applications icon. The one that kinda looks like http://www.iconarchive.com/icons/jonas-rask/pry-system/256/Applications-icon.png

@tphalp
Copy link

tphalp commented Oct 10, 2014

Yes, I've seen that as well, but very rarely.

@adam-lynch
Copy link
Contributor

Some fixes were made around this. Should be ok with the latest version. Thanks for reporting.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants