-
-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build system: windows support + stylua style checker #25
Conversation
|
Thanks for testing. Wanna try and pull again? I don't think i need to support everything but i think supporting |
Latest commit 23a2f10 works as expected on OpenBSD. Thanks for checking in. |
Makefile
Outdated
RM = cmd //C rmdir //Q //S | ||
CC = gcc |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no need to double //, that is only necesary for the other slash(\\
) -> RM = cmd /C rmdir /Q /S
.
(With double // doesn't work)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So you can't even blindly trust stackoverflow 🤣
also, the Thank you for supporting windows platform 👍 |
I'll remove the |
Everything works OK! |
So we can merge it. Thanks for testing :) |
Close #24
@luisiacc Can you try if this works now? Out of the box. So checkout branch and
make clean && make
@ryanreno Can you check if OpenBSD still works after that. I need to force
CC=gcc
for windows. windows doesn't havecc
. I only set it if the OS is windows but i still wanted to ask, if you can test it. Thanks :)