Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build system: windows support + stylua style checker #25

Merged
merged 3 commits into from
Jun 16, 2021

Conversation

Conni2461
Copy link
Member

Close #24

@luisiacc Can you try if this works now? Out of the box. So checkout branch and make clean && make

@ryanreno Can you check if OpenBSD still works after that. I need to force CC=gcc for windows. windows doesn't have cc. I only set it if the OS is windows but i still wanted to ask, if you can test it. Thanks :)

@luisiacc
Copy link

make works well now, make clean throws error(regular windows stuff), I had to manually remove build folder.

rm -rf build
process_begin: CreateProcess(NULL, rm -rf build, ...) failed.
make (e=2): The system cannot find the file specified.
make: *** [clean] Error 2

@Conni2461
Copy link
Member Author

Thanks for testing. Wanna try and pull again?

I don't think i need to support everything but i think supporting make and make clean on windows makes sense :)

@ryanreno
Copy link
Contributor

Latest commit 23a2f10 works as expected on OpenBSD. Thanks for checking in.

Makefile Outdated
Comment on lines 5 to 6
RM = cmd //C rmdir //Q //S
CC = gcc
Copy link

@luisiacc luisiacc Jun 15, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no need to double //, that is only necesary for the other slash(\\) -> RM = cmd /C rmdir /Q /S.
(With double // doesn't work)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So you can't even blindly trust stackoverflow 🤣

@luisiacc
Copy link

luisiacc commented Jun 15, 2021

also, the -p folder is still being created, so when you make again, it throws an error that it was already created, and then it doesn't make at all.
So I'd suggest to remove the -p on the make command(on windows of course), or to add it on the RM command like rmdir /q /s -p build

Thank you for supporting windows platform 👍

@Conni2461
Copy link
Member Author

I'll remove the -p on windows and i add a minus in front of mkdir so it doesn't throw an error if it fails (build dir already exist). Give me 5min :)

@luisiacc
Copy link

luisiacc commented Jun 16, 2021

Everything works OK!

@Conni2461
Copy link
Member Author

So we can merge it. Thanks for testing :)

@Conni2461 Conni2461 merged commit f0379f5 into main Jun 16, 2021
@Conni2461 Conni2461 deleted the windows_support branch June 16, 2021 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Better windows support (makefile)
3 participants