feat: List toggling/inverting for sublists #1492
Conversation
| ---@param match_self boolean #If true can match on self, if false needs to match on ancestor to node | ||
| ---@return TSNode? | ||
| -- TODO: if remove match_self param, need to check other functionality that depends on this | ||
| find_parent = function(node, types, match_self) |
There was a problem hiding this comment.
Not sure if this was intended functionality but the previous version of this method allowed to match on the node passed so I had to include this param to stricly match on ancestor. The default is to keep the previous behavior (match_self = true).
| node = node:parent() | ||
| end | ||
|
|
||
| if type(types) == "string" then |
There was a problem hiding this comment.
Simplified the method so we're only working with one type of param (table) otherwise should behave the same way. For tables it also used to check for equality whereas now it does pattern matching. If a string is passed that is not a pattern it should behave the same way
| ---@param types table|string #If `types` is a table, this function will attempt to match any of the types present in the table. | ||
| -- If the type is a string, the function will attempt to pattern match the `types` value with the node type. | ||
| find_parent = function(node, types) | ||
| local _node = node |
There was a problem hiding this comment.
not really sure what this local _node was doing so I removed it. Also added the TSNode typehint to get rid of the ignore diagnostic comments cc: @pysan3
| local parent = module.required["core.integrations.treesitter"].find_parent(node, { | ||
| "^unordered_list%d$", | ||
| "^ordered_list%d$", | ||
| "^generic_list$", -- for level 1 lists the parent is a generic_list |
There was a problem hiding this comment.
because find_parent can now accept patterns we can now change this to also be a list of pattern instead of an exhaustive list
|
Great work, unfortunately the refactor of the find_parent function seems to have broken quite a lot of functionality that relied on it. An example is link resolution: pressing on a simple link will cause the link resolver to fail. I don't think I have the time to track down the source of the issue for this release, but I can sure come back to this and we can try to figure it out :) |
|
Hey @vhyrro thank you for the heads up I can look into it and clean this pr up a bit. I'll ping her once again once I get that out. |
mtrajano
force-pushed
the
toggle-lists-fix
branch
2 times, most recently
from
6374d45
to
aeb286b
Compare
mtrajano
force-pushed
the
toggle-lists-fix
branch
from
aeb286b
to
63dfb8b
Compare
mtrajano
changed the title
|
@vhyrro updated the previous pr. Essentially kept the scope of changes to just the pivot module to prevent the other breaking changes. Open to any feedback/improvements you may have |
|
Fantstic, thank you! I've been unable to break it in my testing and it works much better than the current implementation :) |
First pass. Might still need some cleaning up but toggling / inverting sublists is working. I can also write some tests for this, what is the status on testing? Do we have this set up already?
Demo:
Screen.Recording.2024-06-28.at.3.45.13.PM.mov