Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(presenter): ensure module.private is not overriden #1037

Merged
merged 1 commit into from
Sep 2, 2023
Merged

fix(presenter): ensure module.private is not overriden #1037

merged 1 commit into from
Sep 2, 2023

Conversation

tamton-aquib
Copy link
Contributor

@tamton-aquib tamton-aquib commented Sep 2, 2023 •
edited
Loading

module.private was overriden so current_page was nil when starting instead of 1 by default.

@vhyrro vhyrro merged commit c9dd9f7 into nvim-neorg:main Sep 2, 2023
1 check passed
@github-actions github-actions bot mentioned this pull request Sep 2, 2023
Merged
benlubas pushed a commit to benlubas/neorg that referenced this pull request Jan 11, 2024
@tamton-aquib @benlubas
fix(presenter): ensure module.private is not overriden (nvim-neorg#1037)
4ca346b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vhyrro vhyrro Awaiting requested review from vhyrro vhyrro is a code owner

@mrossinek mrossinek Awaiting requested review from mrossinek

@danymat danymat Awaiting requested review from danymat

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tamton-aquib @vhyrro