Use legacy winConsole support by default for 2019.3

[michaelDCurran]

Link to issue number:

Temporarily addresses #10600 and #10618

Summary of the issue:

Dispite lots of work from @codeofdusk , myself and others on the new UIA winConsole support, there are still bugs in Microsoft's implementation which we cannot work around. Specifically some people are still experiencing issues when reviewing text on some builds of Windows, users are complaining of lags, and if the screen is flooded with text, new text announcement may stop all together due to UIA core receiving too many events.

Description of how this pull request fixes the issue:

For 2019.3, make legacy the default. Users can still choose to use the UIA implementation from NVDA's advanced settings if they wish.
I personally will continue to use the UIA implementation as I experience no issues with it in the way I use it on a day to day basis. However, we need to release 2019.3 as soon as possible, and we would prefer to minimize the amount of extra changes. We hope to work with Microsoft to address the issues in their UIA implementation in the near future, so that we can again make UIA in Windows consoles the default.

Testing performed:

Ran a copy of NVDA on Windows 10 2004 with a new configuration, ensuring that NVDA used the legacy console support. Switched to UIA Prefered in NVDA's advanced settings, and ensured that UIA winConsole support was being used.

Known issues with pull request:

None.

Change log entry:

None needed.

[josephsl]

Thanks - I think we should revisit this in 2020.1.

[codeofdusk]

#9771 should be fully reverted, as it also includes some UI changes having to do with making UIA the default. Bill

…

Sent from my iPhone

On Jan 13, 2020, at 19:36, Michael Curran ***@***.***> wrote:  Link to issue number: Temporarily addresses #10600 and #10618 Summary of the issue: Dispite lots of work from @codeofdusk , myself and others on the new UIA winConsole support, there are still bugs in Microsoft's implementation which we cannot work around. Specifically some people are still experiencing issues when reviewing text on some builds of Windows, users are complaining of lags, and if the screen is flooded with text, new text announcement may stop all together due to UIA core receiving too many events. Description of how this pull request fixes the issue: For 2019.3, make legacy the default. Users can still choose to use the UIA implementation from NVDA's advanced settings if they wish. I personally will continue to use the UIA implementation as I experience no issues with it in the way I use it on a day to day basis. However, we need to release 2019.3 as soon as possible, and we would prefer to minimize the amount of extra changes. We hope to work with Microsoft to address the issues in their UIA implementation in the near future, so that we can again make UIA in Windows consoles the default. Testing performed: Ran a copy of NVDA on Windows 10 2004 with a new configuration, ensuring that NVDA used the legacy console support. Switched to UIA Prefered in NVDA's advanced settings, and ensured that UIA winConsole support was being used. Known issues with pull request: None. Change log entry: None needed. You can view, comment on, or merge this pull request online at: #10682 Commit Summary Use legacy winConsole support by default for 2019.3 as there are still users in the community for whom the new support is very problematic. File Changes M source/config/configSpec.py (2) M user_docs/en/changes.t2t (3) Patch Links: https://github.com/nvaccess/nvda/pull/10682.patch https://github.com/nvaccess/nvda/pull/10682.diff — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or unsubscribe.

[codeofdusk]

In particular, the behavior of auto should be changed, and not the config spec default. The combo box should also be reverted to a checkbox (all pre #9771 state).

[michaelDCurran]

I don't think there is any need to revert #9771 as it includes a lot of changes that if reverted would affect the functionality of UIA winConsole support if enabled. I think for 2019.3 simply changing the default to legacy is enough to protect most users. Yet for those who want to use the new functionality, they have the full implementation if they want it. We really do want to turn this on by default when possible.

[michaelDCurran]

I think auto should be left as a valid option. That is certainly what I would personally use in a portable copy of NVDA. Allowing me to use UIA on any Windows build suitable enough to support it. And also, reverting so much in a beta is a risk in itself.

[codeofdusk]

I don't think there is any need to revert #9771 as it includes a lot of changes that if reverted would affect the functionality of UIA winConsole support if enabled. I think for 2019.3 simply changing the default to legacy is enough to protect most users. Yet for those who want to use the new functionality, they have the full implementation if they want it. We really do want to turn this on by default when possible.

How does reverting #9771 adversely affect the behavior of UIA console, other than not making it the default and restoring the UI and functionality of auto to how it was in 2019.2?

[michaelDCurran]

#9771 contains a lot of changes to source/NVDAObjects/UIA/UIAWinConsole.py. Most of them are style changesI think, but it seems silly and risky to revert all that when it is going to be put back into master straight away anyway. All we really want to do here is just ensure that by default, users get legacy on 2019.3.

[feerrenrut]

Sorry, I missed this notification last week. For what it's worth, this looks ok.