Revert selection message being at the end for list cases #9894
Comments
|
Hi, the other day I was thinking we should add a Boolean (checkbox) setting that allows people to specify the old or the new behavior. What do you think? CC @LeonarddeR
|
|
I love checkboxes. Well, I guess all of you already knew that. 😉 |
|
No, I think we should just remove the new behavior in this specific case. it's a special case. We don't need NVDA being littered with hundreds of one-off decision checkboxes. |
|
Yes it would be nice to have this as a choice,as long as it still works as a
toggle on each item to alter the state when you hit space.
Brian
[email protected]
Sent via blueyonder.
Please address personal E-mail to:-
[email protected], putting 'Brian Gaff'
in the display name field.
Newsgroup monitored: alt.comp.blind-users
-----
|
|
Well I don't really agree, as its hardly a complex thing but can allow
people to configure it and leave it. Default it to whatever you like, but
the mere fact we have had it both ways in the past proves to me that there
is push back against one or the other behaviour, or nobody would have
altered it!
Brian
[email protected]
Sent via blueyonder.
Please address personal E-mail to:-
[email protected], putting 'Brian Gaff'
in the display name field.
Newsgroup monitored: alt.comp.blind-users
-----
|
|
I am testing with 2019.1.1 and selected/nos selected is reported at the end in these cases. @derekriemer Are your certain that it is a regression? |
|
@lukaszgo1 Are you testing with the English version of NVDA? It could be that the translators of your particular language decided to swap the order. I agree with @derekriemer. the selected state should be announced before the list item in these cases. |
|
Yes, I've tested with the 2019.1.1 in English, and not selected is announced at the end, selected however isn't announced at all when navigating with CTRL+arrows. |
Exactly the same behavior on my machines with NVDA 2015.3/2018.1 (I'm waiting for 2019.2) on Win7x64 – both German GUI (incl. NVDA).
I suppose it wouldn't be bad to talk about this in a separate issue or in the translators' mailing list. |
|
@josephsl, The request to make it configurable was in the comments of the PR I
believe, though not acted upon.
I disagree with the "too much configurability" argument. People like choice.
When it comes to saying "selected" before or after text, people have arguments
on both sides, and enough prefer it each way that it should really be a
checkbox. See #1707 for some of the arguments, just as one example.
For the case of selecting files, however, it almost certainly should be
announced before the (un)selected name, regardless of any checkbox.
|
|
I don't believe there is a regression here so I'm going to close this issue. If you get different results on some system please add a comment. For each preference (selected first vs last) there are good justifications. Collecting these user stories may help us to innovate in this area, see #6757 (comment) for an example of similar user stories. Sometimes this is just a matter of preference, NV Access has goals to improve the configurability of the NVDA speech user experience and even suggested it as a project idea for Google Summer of Code. However, creating a check box for every variation will make configuration for users difficult and maintenance for developers difficult. Test method
ResultsFor 2019.1, latest beta build, and 2017.3 the output was all identical ( except for the time). See detailed output below. 2019.1:Latest Beta (beta-18022,dc5c0b8c)2017.3 |
Steps to reproduce:
Actual behavior:
NVDA says "blah blah blah" before selected or unselected.
Expected behavior:
As before, NVDA should say selected or unselected before the message, but only when selection changes.
NVDA version:
Version: alpha-17928,9dfbd2ee
Regression caused by #9028
The text was updated successfully, but these errors were encountered: