-
-
Notifications
You must be signed in to change notification settings - Fork 651
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NVDA is not reading expanded/collapsed on button with aria-haspopup as "true" #9096
Comments
This works in Firefox 65 beta 5. |
I'm still seeing this issue on (for example) the w3c example here |
@LeonarddeR Facing this issue in chrome till now. |
If I understand this correctly, the string "expanded" or "colapsed" is sent to the screen reader via aria has popup. This popup is interupted by the focus event, the focus jumps to the menu item. cc: @ObjectInSpace |
It seems if Firefox this is working as expected. But in borth browsers, the status "colapsed" is not reported when colapsing the menu. |
It only reads "expanded" in Firefox if focus mode is on. I also notice that the state of the button is not read when reviewing it in either browser. Shouldn't it say if the menu is collapsed or expanded when the button is focused? |
it seems NVDA reports "expanded" when the button is expanded and you focus it with arrow keys. But this does not work when the button is colapsed. NVDA does not report it, for what ever reason. Neither when focussing, nor when pressing enter on the button. |
The reason the state of the menu isn't read when the menu is collapsed on either of the following two w3C example pages is because when the menu is collapsed, they remove the
-- Rich |
This is not an authoring error. w3c docs specifically recommend removing the attribute when the menu is hidden/collapsed. See here: w3c/aria-practices#1318 (comment) |
On an element with either "listbox" or "combobox" role, I expect the screen reader to announce "expanded" or "collapsed" depending on the value of the aria-expanded attribute. |
Now it seems the Expanded status is reported correctly every time in last NVDA Alpha. Still the colapsed status is not reported. |
I confirm that the problem still exists. |
Was facing similar issue on chrome after adding role button fixed the issue on chrome. now it reads expanded collapsed on chrome |
on chrome it is ok now, but on firefox the problem still persists. |
The same issues are happening on Chrome in the W3C's combobox examples here: https://www.w3.org/TR/wai-aria-practices/examples/combobox/aria1.1pattern/listbox-combo.html Should I file a different issue for combobox or is adding onto this bug the same underlying issue? |
This issue is not very clear. In future please copy the exact speech that hear (use speech viewer to help) and paste under the title "actual behavior". Then you can edit this for the "expected behavior". When using the W3C example:
Then pressing "enter" to open the menu, NVDA speaks:
Then pressing "esc" to close the menu, NVDA speaks:
Maybe this output from NVDA can be more clear, however I want to note that a screen reader should not simply report all aria attributes to the user. NVDA needs to present as complete as possible information to the user, while minimizing verbosity. Let me break down each of these steps:
I'm happy to discuss this further, and I'm certainly willing to look at ways this can be improved, but please be very clear with your descriptions of behavior, and ideally also tell us why you think it should change. |
Again please let me know if this should necessitate its own issue. For the case of combobox with has-popup announcing expanded / collapsed: Steps to Reproduce:
Actual Behavioron focus: on typing "a": on typing "z": Expected Behavioron focus: on typing "a": or "a, autocomplete has 3 suggestions, <perhaps instructions on navigating the combobox?>" on typing "z": or "z, autocomplete has 0 suggestions" ReasoningGranted NVDA will mention that there is a collapsed combobox and it is an autocomplete, but there is no indication of whether to navigate down or not as the user continues to type. If the user does press If the user were to type |
Thanks for the clear write up @e111077. I think your comment would indeed be better as a new issue. |
If I added child element with combobox in aria-control container, then the 'collapsed' and 'expanded' will not announced. If I removed the child element it work. |
As a supplement to the previous comment. |
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
Do we have any update on this issue? It seems the issue still exists. Below screenshot has my finding with NVDA+ Chrome. However the voiceover(MacOS) is announcing it as " |
@JaiRai0304 note that here are a lot of blind developers. We need the screenshot as a plain text so we can read it with the screen reader. Firefox > NVDA browse mode:
firefox > NVDA focus mode:
Chromium > NVDA browse mode:
Chromiuim focus mode:
cc: @jcsteh could you have a look at the Firefox part? There might be already bugs filled for that in Bugzilla. |
hi @Adriani90 - I tested with NVDA version 2021, and NVDA version 2023 on chrome browser. |
That is expected behavior and is consistent with all menus with submenus in Windows. For this menu submenu case there is no need to report colapsed or expanded when focussing it, but Only when performing the action and not redirecting focus.Von meinem iPhone gesendetAm 05.04.2023 um 09:32 schrieb Jai Prakash Rai ***@***.***>:
hi @Adriani90 -
Thanks for your review, and In future I will add screenshots as plain text.
I tested with NVDA version 2021, and NVDA version 2023 on chrome browser.
In focus mode, when i am landing to menuitems, NVDA not announcing the collapsed state of the menuitems.
For me it's announcing as " About Submenu 2 of 4" .
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you were mentioned.Message ID: ***@***.***>
|
What I would expect here is that NVDA always reports "menu" and switches to focus mode when the menu is expanded. That is, focus should be redirected to the menu if it isn't redirected elsewhere by the web page. Chrome doesn't ever seem to do this, though, and Firefox is inconsistent. I'm not sure why yet, nor am I sure why Chrome is deviating here. I'll look into it. NVDA intentionally doesn't report collapsed on a menu item which has a sub-menu because you normally reach such menu items with focus and you can't reach menu items with focus unless they're collapsed. This makes the collapsed/expanded state redundant.
The menu contains a separator between the two groups of items. Firefox considers separators when counting, stopping when it reaches a separator. Without this, users wouldn't be able to tell that there are two separated groups of items. |
The menu contains a separator between the two groups of items. Firefox considers separators when counting, stopping when it reaches a separator. Without
this, users wouldn't be able to tell that there are two separated groups of items.
Can we report something like "1 of 4 in group" under these circumstances? Or "1
of 4 in first group", "1 of 4 in second group" . . .
|
I am not sure if I should open a new issue regarding the count elements in group of elements with separators. Actually NVDA does not report that this is a group of elements. Separators can have a label, but since they are not focusable in focus mode I am not sure NVDA would report that label though. I found an interesting discussion here which recommends rather using the group role with a label instead of separator labels. In any case, i think a combination of separators and group roles would make obvious for users that there are group of elements and how many elements are in each group. This is in the responsibility of the web author to use them correctly. |
Hi team, Any update on this issue? |
Current status:
For 2, a new issue needs to be opened filling the bug template. Also two more issues arose while discussing this:
|
Hi @Adriani90 , This issue is closed at our end.If we face issue further we will log a new one.Thanks |
Steps to reproduce:
(url button_exp_col.txt)
Actual behavior:
NVDA is not reading "aria-expanded" property as expanded or collapsed on toggling the button
Expected behavior:
NVDA must read "aria-expanded" property as expanded or collapsed on toggling the button
System configuration:
win 10, 64-bit operating system, 16GB RAM
NVDA installed/portable/running from source:
Installed on system
NVDA version:
2018.4
Windows version:
Chrome Version 71.0.3578.98 (Official Build) (64-bit)
Name and version of other software in use when reproducing the issue:
NA
Other information about your system:
NA
Other questions
Does the issue still occur after restarting your PC?
Yes
Have you tried any other versions of NVDA?
No
The text was updated successfully, but these errors were encountered: