Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Serbian translation no longer loaded #15943

Closed
nidza07 opened this issue Dec 19, 2023 · 6 comments
Closed

Serbian translation no longer loaded #15943

nidza07 opened this issue Dec 19, 2023 · 6 comments

Comments

@nidza07
Copy link
Contributor

nidza07 commented Dec 19, 2023

Steps to reproduce:

  1. Run the latest NVDA alpha build.
  2. In general settings, set the language to Serbian (Latin), sr
  3. Confim NVDA restart after changing the language.

Actual behavior:

NVDA's interface remains in English. Note that addon translations continue to work fine, as long as the addon you are using is indeed translated.

Expected behavior:

NVDA's interface should be in Serbian.

Debug log:

NVDA SR not working.log

System configuration

NVDA installed/portable/running from source:

Reproduces with installed or portable

NVDA version:

alpha-30343,6200e9bf (2024.2.0.30343)

Windows version:

Windows 10 22H2 (AMD64) build 19045.3803

Other questions

Does the issue still occur after restarting your computer?

Yes

Have you tried any other versions of NVDA? If so, please report their behaviors.

The issue does not reproduce with alpha-30327,0db95520, but starts with alpha-30335,0632ee86

If NVDA add-ons are disabled, is your problem still occurring?

Yes

Does the issue still occur after you run the COM Registration Fixing Tool in NVDA's tools menu?

Yes

@lukaszgo1
Copy link
Contributor

@michaelDCurran It seems something went wrong when importing Serbian translation from Crowdin. It looks like no string is translated, even though in the previous Alpha translation was quite complete. From a quick, and done in a very unprofessional (I've just sorted NVDA's mo files by size, and verified that the only one aside from Serbian being 1 kb in size is for Bengali, which was not translated) way, only Serbian appears to be affected.

@michaelDCurran
Copy link
Member

michaelDCurran commented Dec 19, 2023

It seems that NVDA's existing sr translation, Serbian (Latin), was incorrectly imported to Crowdin as Serbian (Cyrillic). I have re-imported NVDA's existing sr translation to Crowdin as Serbian (Latin), and exported the translation back into the NVDA beta branch, thereby restoring the sr translation. This issue can be closed once beta has been merged to master and a resulting alpha snapshot is checked to ensure all existing sr translation is there.

@Adriani90
Copy link
Collaborator

Note that Serbian cyrillic is a different alphabet which is used by about 40% of the population , in contrast about 47% use the latin alphabet there. So if someone wants to integrate Serbian cyrillic in NVDA, this should probably be done by integrating it as a new language I guess.

@nidza07
Copy link
Contributor Author

nidza07 commented Dec 19, 2023

@Adriani90 This does not make a lot of sense for the majority of blind users. It is absolutely true that it is a different alphabet, but only the visual look of the script itself is different, and 3 additional letters. The pronunciation for a screen reader remains absolutely the same. In fact, if we were to have Serbian Cyrillic in NVDA, it would mostly consist of a script to replace latin letters with their Cyrillic equivalents, something that I don't see a lot of benefits.
The 3 additional letters mentioned above are written using a combination of letters in the Latin alphabet.

Originally, NVDA was indeed translated using Cyrillic. The conversion to Latin happened somewhere around 2015, and it was mostly done for practical reasons. At that time, there were many synthesizers unable to read the Cyrillic alphabet, so it was decided to give as many people access to the translation as possible.
Nowadays, this is probably not such a big concern anymore, but similarly there isn't really a huge reason to change this decision. Anyway, this is not really important for this issue, so if you are interested in any more details, feel free to get in touch.

Thanks to Michael for such a quick fix. As mentioned, I'll close the issue as soon as a merge to alpha happens and I can confirm that everything works as expected.

@Adriani90
Copy link
Collaborator

Adriani90 commented Dec 20, 2023 via email

@nidza07
Copy link
Contributor Author

nidza07 commented Dec 20, 2023

This is now fixed in the latest alpha, and I confirm that it works as expected. Thank you!

@nidza07 nidza07 closed this as completed Dec 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants