Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG]: Incompatible to_json call w/Pandas 2 #1895

Open
2 tasks done
cwharris opened this issue Sep 18, 2024 · 0 comments
Open
2 tasks done

[BUG]: Incompatible to_json call w/Pandas 2 #1895

cwharris opened this issue Sep 18, 2024 · 0 comments
Assignees
Labels
bug Something isn't working

Comments

@cwharris
Copy link
Contributor

cwharris commented Sep 18, 2024

Version

24.10

Which installation method(s) does this occur on?

No response

Describe the bug.

Pandas 2 introduced error-raising behavior when calling to_json with incompatible orient and index arguments, which presents itself in Morpheus when using Pandas 2 (discovered while updating RAPIDS). The old Pandas behavior was to ignore index=True when orient="records", as seen in this issue. The error-producing behavior was introduced in this PR.

The error-raising behavior needs to be avoided. An easy work around is to simply use index=False here, and ignore the value passed in by calling code, but this may confuse the caller. Since we allow calling code to inject the index argument, we may need to issue a warning when the index argument is incompatible and adjust it accordingly.

Code of Conduct

  • I agree to follow Morpheus' Code of Conduct
  • I have searched the open bugs and have found no duplicates for this bug report
@cwharris cwharris added the bug Something isn't working label Sep 18, 2024
@mdemoret-nv mdemoret-nv added this to the 24.10 - Release milestone Sep 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Todo
Development

No branches or pull requests

2 participants