Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

slow reduction operations in cunumeric (at least for Nonzero) #506

Closed
rohany opened this issue Aug 5, 2022 · 1 comment
Closed

slow reduction operations in cunumeric (at least for Nonzero) #506

rohany opened this issue Aug 5, 2022 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@rohany
Copy link
Member

rohany commented Aug 5, 2022

Based on discussions offline with @magnatelee, it appears that cunumeric's reduction operations are relatively slow. I replaced the reduction operation of "count_non_zeros" in the Nonzero task with a thrust::transform_reduce, and found that I achieved much better performance. I also tested out removing the accessor and directly indexing the input buffers and saw little change in performance.

@rohany
Copy link
Member Author

rohany commented Aug 6, 2022

This is addressed now -- tested on sean-dgx2 and saw the same performance as the thrust implementation.

@rohany rohany closed this as completed Aug 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants