feat: remove lodash-es
#648
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
You are so fast. |
|
I can close it, if you were planning to work on it, im suuuure you will do a better job than me, just let me know 🙏 |
danielroe
reviewed
Sep 10, 2023
danielroe
reviewed
Sep 10, 2023
danielroe
reviewed
Sep 10, 2023
danielroe
reviewed
Sep 10, 2023
|
No, let's do this! I would recommend also rewriting some of the code so it doesn't need these helper functions and is more obvious in location what it does. (Some of the more advanced use cases of lodash's helpers aren't actually used in the nuxt/ui code, I think.) |
danielroe
force-pushed
the
feat/remove-lodash
branch
from
7dd0c98
to
f46ae6d
Compare
Merged
danielroe
approved these changes
Sep 14, 2023
benjamincanac
approved these changes
Sep 14, 2023
Haythamasalama
pushed a commit
to Haythamasalama/ui
that referenced
this pull request
Sep 21, 2023
Co-authored-by: Daniel Roe <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #642 and resolves #311