Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Input)!: redesign file type without absolute positioning #1712

Merged
merged 1 commit into from
Apr 25, 2024

Conversation

benjamincanac
Copy link
Member

@benjamincanac benjamincanac commented Apr 24, 2024

πŸ”— Linked issue

Resolves #1524, resolves #1412

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@HigherOrderLogic
Copy link
Contributor

Shouldn't we bundle this with the V3 change?

I don't think it's ideal to release a breaking change now that V3 is being developed.

@moshetanzer
Copy link
Collaborator

moshetanzer commented Apr 24, 2024

@HigherOrderLogic Nope. I think @benjamincanac go for it. People are using this in projects already and the current version doesn't display properly in Safari. Also @HigherOrderLogic what do you mean by breaking?

Copy link
Member Author

This was a change I made in v3 initially but as its completely broken at the moment on Safari and doesn't work with icons I think we should fix it also there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Issues with UInput using type File Input: handle type file (added in 2.14)
3 participants