-
Notifications
You must be signed in to change notification settings - Fork 544
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(Accordion): add unmount
prop to allow lazy mounting for heavy components
#1590
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would have been easier to to just handle the unmount
prop on the DisclosurePanel
component without the static
and v-show
but if I remember correctly it breaks the transition.
Yes that's exactly why I use the reuseTemplate, because static requires us to handle the div with a v-show or v-if around for the display condition |
@noook This seem to break the whole documentation: https://ui-7z2kyn5b0-nuxt-js.vercel.app/components/accordion |
unmount
prop to allow lazy mounting for heavy components
I don't know why |
π Linked issue
β Type of change
π Description
When dealing with Accordion with 10+ more list items that have heavy components inside the disclosure, every state change on the accordion items can slow down or block the page.
This PR allows configuring the DisclosurePanel to not be mounted unless the panel is open. When unmount is false (default), the previous behaviour (static) applies.
π Checklist