feat: universal meta resolving #55
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Ahad Birang <[email protected]>
pi0
commented
Oct 28, 2020
farnabaz
approved these changes
Nov 2, 2020
pi0
commented
Nov 2, 2020
procrates
pushed a commit
to procrates/nuxt-image
that referenced
this pull request
Feb 21, 2023
Co-authored-by: Ahad Birang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we was depending on providers to resolve image meta (getting aspect ratio and also base64) this was adding complexity and sometimes extera requests. With this PR, using nuxt-contrib/image-meta (for Node.js) and
Image+Canvas(for Browser), we can universally have ratio. (Future release ofimage-metamay eventually support Node.js if we can remove Buffer dependency)