Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(twicpics): fix modifiers and improve documentation #503

Merged
merged 5 commits into from
Jun 21, 2022
Merged

feat(twicpics): fix modifiers and improve documentation #503

merged 5 commits into from
Jun 21, 2022

Conversation

mbgspcii
Copy link
Contributor

@mbgspcii mbgspcii commented Apr 5, 2022

TwicPics provider:

  • fixes fit=contain feature
  • fixes fit=inside feature
  • fixes fit=outside feature
  • additional documentation and playground samples

@mbgspcii mbgspcii changed the title Features/twicpics additionnal documentation feat(provider): twicpics - additionnal documentation Apr 5, 2022
atinux
atinux reviewed Apr 5, 2022
View reviewed changes
Copy link
Member

@atinux atinux left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added some comments, thank you for this PR ❤️

@mbgspcii mbgspcii force-pushed the features/twicpics_additionnal_documentation branch from a07b555 to 81ec25e Compare April 6, 2022 12:41
@mbgspcii mbgspcii requested a review from atinux April 10, 2022 09:30
@mbgspcii mbgspcii force-pushed the features/twicpics_additionnal_documentation branch from 81ec25e to 77232da Compare April 15, 2022 08:10
@pi0 pi0 changed the title feat(provider): twicpics - additionnal documentation feat(twicpics ): fix modifiers and improve documentation Jun 20, 2022
@pi0 pi0 changed the title feat(twicpics ): fix modifiers and improve documentation feat(twicpics): fix modifiers and improve documentation Jun 20, 2022
@pi0
Copy link
Member

pi0 commented Jun 21, 2022

Thanks @mbgspcii @atinux for working on this 💯

@pi0 pi0 merged commit 7942232 into nuxt:main Jun 21, 2022
pi0 added a commit that referenced this pull request Jun 21, 2022
@pi0
test: update twicpics tests
8601e61 
#503
procrates pushed a commit to procrates/nuxt-image that referenced this pull request Feb 21, 2023
@mbgspcii
feat(twicpics): fix modifiers and improve documentation (nuxt#503)
3ce4746 
Co-authored-by: Miguel Beignon <[email protected]>
procrates pushed a commit to procrates/nuxt-image that referenced this pull request Feb 21, 2023
@pi0
test: update twicpics tests
ad73348 
nuxt#503
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pi0 pi0 pi0 approved these changes

@atinux atinux Awaiting requested review from atinux

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mbgspcii @pi0 @atinux