feat: glide provider #328
feat: glide provider #328
Conversation
Codecov Report
@@ Coverage Diff @@
## main #328 +/- ##
===========================================
- Coverage 59.09% 14.44% -44.65%
===========================================
Files 25 24 -1
Lines 594 533 -61
Branches 178 135 -43
===========================================
- Hits 351 77 -274
- Misses 243 456 +213
Continue to review full report at Codecov.
|
|
Thanks 🙌 Would you mind also updating playground and docs to add new provider? |
|
The only glide instance that I have hosted is the one I use at work... not sure if they would be super happy having it in examples. Do you have any suggestions for the best way to provide a glide instance? Maybe I can host one on Heroku? |
|
We usually use examples in provider documentation. For glide i could find this: https://glide.herokuapp.com/1.0/kayaks.jpg?w=1000&gam=.9&sharp=8 |
| @@ -87,6 +88,17 @@ describe('Providers', () => { | |||
| } | |||
| }) | |||
|
|
|||
| test('glide', () => { | |||
There was a problem hiding this comment.
/refactor note: We may auto generate tests with a loop (/cc @danielroe)
https://glide.thephpleague.com/2.0/api/quick-reference/
resolves #326