Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for netlify provider #299

Merged
merged 7 commits into from
May 29, 2021
Merged

feat: add support for netlify provider #299

merged 7 commits into from
May 29, 2021

Conversation

danielroe
Copy link
Member

@danielroe danielroe commented May 29, 2021

This adds support for the Netlify image transformation service.

Note that if you want to use this, you will need to enable Netlify Large Media on Netlify.

More information: https://docs.netlify.com/large-media/transform-images/

BREAKING CHANGE: if you are deploying on netlify you will either need to enable Netlify Large Media or pick another provider
@codecov-commenter
Copy link

codecov-commenter commented May 29, 2021

Codecov Report

Merging #299 (dc2ee43) into main (828b9f9) will increase coverage by 0.65%.
The diff coverage is 77.77%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #299      +/-   ##
==========================================
+ Coverage   57.43%   58.08%   +0.65%     
==========================================
  Files          24       25       +1     
  Lines         545      563      +18     
  Branches      161      169       +8     
==========================================
+ Hits          313      327      +14     
- Misses        232      236       +4     
Impacted Files Coverage Δ
src/provider.ts 72.22% <ø> (ø)
src/runtime/providers/netlify.ts 77.77% <77.77%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 828b9f9...dc2ee43. Read the comment docs.

@danielroe danielroe changed the title feat!: add support for netlify provider feat: add support for netlify provider May 29, 2021
@danielroe danielroe requested a review from pi0 May 29, 2021 10:13
@pi0 pi0 merged commit 003e144 into main May 29, 2021
@pi0 pi0 deleted the feat/netlify-provider branch May 29, 2021 10:24
procrates pushed a commit to procrates/nuxt-image that referenced this pull request Feb 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants