Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: don't allow undefined values to override defaults #274

Merged
merged 1 commit into from
May 17, 2021

Conversation

danielroe
Copy link
Member

closes #273

@danielroe danielroe requested a review from pi0 May 17, 2021 09:03
@codecov-commenter
Copy link

Codecov Report

Merging #274 (e5f34e0) into main (7e06ea6) will decrease coverage by 42.51%.
The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##             main     #274       +/-   ##
===========================================
- Coverage   56.47%   13.96%   -42.52%     
===========================================
  Files          22       20        -2     
  Lines         517      451       -66     
  Branches      129      115       -14     
===========================================
- Hits          292       63      -229     
- Misses        225      388      +163     
Impacted Files Coverage Δ
src/runtime/image.ts 0.00% <0.00%> (-68.87%) ⬇️
src/runtime/providers/cloudinary.ts 0.00% <0.00%> (-80.96%) ⬇️
src/runtime/providers/imgix.ts 0.00% <0.00%> (-100.00%) ⬇️
src/runtime/providers/fastly.ts 0.00% <0.00%> (-100.00%) ⬇️
src/runtime/providers/static.ts 0.00% <0.00%> (-100.00%) ⬇️
src/runtime/providers/ipx.ts 0.00% <0.00%> (-84.62%) ⬇️
src/runtime/components/image.mixin.ts 0.00% <0.00%> (-81.82%) ⬇️
src/runtime/providers/twicpics.ts 0.00% <0.00%> (-72.23%) ⬇️
src/runtime/providers/imagekit.ts 0.00% <0.00%> (-63.64%) ⬇️
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7e06ea6...e5f34e0. Read the comment docs.

@pi0 pi0 merged commit d2e65f9 into main May 17, 2021
@pi0 pi0 deleted the fix/default-modifiers branch May 17, 2021 09:04
procrates pushed a commit to procrates/nuxt-image that referenced this pull request Feb 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cloudinary default modifiers are not applied
3 participants