Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: generate static images even if lazy loaded #233

Merged
merged 2 commits into from
Apr 27, 2021
Merged

Conversation

danielroe
Copy link
Member

closes #232

@danielroe danielroe requested a review from pi0 April 26, 2021 19:09
@codecov-commenter
Copy link

codecov-commenter commented Apr 26, 2021

Codecov Report

Merging #233 (bc9e62d) into main (545a7ee) will increase coverage by 0.11%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #233      +/-   ##
==========================================
+ Coverage   62.58%   62.70%   +0.11%     
==========================================
  Files          23       23              
  Lines         556      555       -1     
  Branches      160      160              
==========================================
  Hits          348      348              
+ Misses        208      207       -1     
Impacted Files Coverage Δ
src/runtime/components/nuxt-img.vue 80.64% <ø> (+2.52%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ad2fac0...bc9e62d. Read the comment docs.

@pi0 pi0 merged commit 5be72a5 into main Apr 27, 2021
@pi0 pi0 deleted the static-images-lazyload branch April 27, 2021 08:19
procrates pushed a commit to procrates/nuxt-image that referenced this pull request Feb 21, 2023
* fix: generate static images even if lazy loaded

closes nuxt#232

* fix: process nsizes as well
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

lazy loading prevents generating static images
4 participants