Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add fastly provider #15

Merged
merged 2 commits into from
Oct 2, 2020
Merged

feat: add fastly provider #15

merged 2 commits into from
Oct 2, 2020

Conversation

btkostner
Copy link
Contributor

This adds a fastly image optimization provider.

  • I tried to get the size operator matched up as much as I could, but they only have three options.
  • I added a fastly url, but because it's a demo url, the only available image to test on is /image.jpg

@codecov-commenter
Copy link

codecov-commenter commented Oct 2, 2020

Codecov Report

Merging #15 into master will increase coverage by 1.62%.
The diff coverage is 75.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #15      +/-   ##
==========================================
+ Coverage   53.16%   54.78%   +1.62%     
==========================================
  Files          15       17       +2     
  Lines         348      376      +28     
  Branches      103      113      +10     
==========================================
+ Hits          185      206      +21     
- Misses        163      170       +7     
Impacted Files Coverage Δ
src/providers/fastly/runtime.ts 73.07% <73.07%> (ø)
src/providers/fastly/index.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 75dba09...bff9648. Read the comment docs.

Copy link
Member

@farnabaz farnabaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, Thanks 👍

@farnabaz farnabaz merged commit 34ceb3c into nuxt:master Oct 2, 2020
procrates pushed a commit to procrates/nuxt-image that referenced this pull request Feb 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants