-
Notifications
You must be signed in to change notification settings - Fork 274
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add storyblok provider #133
Conversation
…om storyblok filters
The image dimension should be included for aspect ratio calculation. See https://www.storyblok.com/faq/image-dimensions-assets-js
|
Also the docs should be updated. |
Thank's for your feedback @tillmon. I am not sure to understand why I have to use it as the dimension of the image will be calculated by stoyblok automatically? Can you elaborate on why I should add it, please? |
I thought this is needed to calculate the space the image is occupying before it is loaded, but I am not sure. |
I am pretty sure it's not useful. |
Can't wait for this to use with storyblok and nuxtjs/image |
Is it just the merge conflict needing to be resolved or is there other issues related to this PR for it to get merged into master? |
I am currently working on it @hoektoe. Thanks for your message :) I need to validate with storyblok team first. |
Awesome, it's just a great integration. Enjoying both nuxtjs and storyblok together. |
Then even after I asked I have no update on it from Storyblok. A bit disappointed :( |
Thanks @f3ltron <3 |
Thanks for your refactor :). I spoke with christian dev at storyblok they have validated it 👍🏼 |
Hi everyone 😄 I double-checked all the features of the Storyblok Image Service and they are working perfectly. Thanks, @f3ltron! 🙌🏻 |
Co-authored-by: Pooya Parsa <[email protected]>
Storyblok provider based on storyblok image service documentation
https://www.storyblok.com/docs/image-service
Added storyblok provider
Added documentation