Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iframe URL ignores baseURL #506

Closed
codehead opened this issue Nov 5, 2023 · 3 comments
Closed

iframe URL ignores baseURL #506

codehead opened this issue Nov 5, 2023 · 3 comments
Labels
bug Something isn't working

Comments

@codehead
Copy link

codehead commented Nov 5, 2023

🐛 The bug

Comments on issue #237 seem to indicate that PR #386 would allow the iframe to be relative to baseURL, but the iframe still points to /__nuxt_devtools__/client/ - this makes nuxt devtools go 404 when the application is accessed through a reverse proxy.

🛠️ To reproduce

https://stackblitz.com/edit/nuxt-starter-s8vyfn?file=nuxt.config.ts

🌈 Expected behavior

Setting baseURL=/prefix/ in nuxt.config.ts

export default defineNuxtConfig({
  app: { baseURL: '/prefix/' },
  devtools: { enabled: true },
});

the iframe should point to /prefix/__nuxt_devtools__/client/ but opening the browser's network monitor or DOM inspector will show that it still points to /__nuxt_devtools__/client/

ℹ️ Additional context

No response

@codehead codehead added the bug Something isn't working label Nov 5, 2023
@fabkho
Copy link

fabkho commented Nov 7, 2023

same for me!

@benje
Copy link

benje commented Nov 20, 2023

Also seeing a 404 when launching the dev tools. Fixing this would be super useful as we are currently unable to use the dev tools for a project that is hosted under a prefix URL.

@antfu antfu closed this as completed in 2697340 Nov 20, 2023
@codehead
Copy link
Author

Great work. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants