Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nuxt module subcommands #8

Closed
2 of 3 tasks
pi0 opened this issue Feb 14, 2023 · 9 comments
Closed
2 of 3 tasks

nuxt module subcommands #8

pi0 opened this issue Feb 14, 2023 · 9 comments
Assignees

Comments

@pi0
Copy link
Member

pi0 commented Feb 14, 2023

@pi0 pi0 self-assigned this Feb 14, 2023
@pi0
Copy link
Member Author

pi0 commented Feb 21, 2023

module search search should fetch latest modules DB from cdn and apply query filter to show modules. Showing their NPM package name, description etc.

Implemented as an internal utility, it should be reused for nuxt module add <name> where name is slug instead of npm package name.

/cc @Intevel do you like to work on it?

@Intevel
Copy link
Collaborator

Intevel commented Feb 21, 2023

module search search should fetch latest modules DB from cdn and apply query filter to show modules. Showing their NPM package name, description etc.

Implemented as an internal utility, it should be reused for nuxt module add <name> where name is slug instead of npm package name.

/cc @Intevel do you like to work on it?

Should that be like a fuzzy-search? Or just it should return the module matches the slug, for e.g.

@pi0
Copy link
Member Author

pi0 commented Feb 21, 2023

Could be nice idea using fuse.js searching through description as well! Popular package managers like apt do similar approach.

@Intevel
Copy link
Collaborator

Intevel commented Feb 21, 2023

Yes, If this is not a problem I would go for the search command.

module search search should fetch latest modules DB from cdn and apply query filter to show modules. Showing their NPM package name, description etc.

Implemented as an internal utility, it should be reused for nuxt module add <name> where name is slug instead of npm package name.

/cc @Intevel do you like to work on it?

@Intevel
Copy link
Collaborator

Intevel commented Feb 22, 2023

@pi0 How do you think the args of the search command should be?

@pi0
Copy link
Member Author

pi0 commented Feb 22, 2023

nuxt module search <qeury>. What do you think?

@Intevel
Copy link
Collaborator

Intevel commented Feb 22, 2023

and what should query contain? The keywords, or/and the name? Or should always be searched with keywords

@Intevel
Copy link
Collaborator

Intevel commented Apr 7, 2023

After merging unjs/nypm#55 I would implement the remove feature.

@pi0
Copy link
Member Author

pi0 commented Jul 6, 2023

Initial commands implemented in: https://github.com/nuxt/cli/tree/main/src/commands/module

PR welcome to support remove + other improvements 🙏🏼

@pi0 pi0 closed this as completed Jul 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants