Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nuxt devtools enable|disable works only with --command flag #69

Closed
AndreyYolkin opened this issue Jul 8, 2023 · 4 comments · Fixed by #119
Closed

nuxt devtools enable|disable works only with --command flag #69

AndreyYolkin opened this issue Jul 8, 2023 · 4 comments · Fixed by #119
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@AndreyYolkin
Copy link
Contributor

AndreyYolkin commented Jul 8, 2023

Problem

According to the docs, users can just type nuxi devtools enable to enable devtools in the project. Howerver, after #47 enable/disable flag can only be submitted with --command before the value.

There I need to ask: which way is preferred for the future? Should we change documentation or fix the command itself?

Extra info to help:

1. There is the code, where nuxi expect to have --command flag:
if (!['enable', 'disable'].includes(ctx.args.command)) {

2. There I logged ctx.args:

image

3. There is the run without --command flag, as documented:

image

4. There is the run with --command flag:

image
@Hebilicious Hebilicious added bug Something isn't working good first issue Good for newcomers documentation Improvements or additions to documentation labels Jul 8, 2023
@AndreyYolkin
Copy link
Contributor Author

Still exists, but after nuxt switched to that CLI, problem affects all user, who wants to enable/disable devtools

@dycops
Copy link

dycops commented Aug 29, 2023

webstorm64_gItssxBJIR copy
Have the same error

@Hebilicious
Copy link
Member

@danielroe should we update the docs to use --command, or change this behaviour ?

@danielroe
Copy link
Member

danielroe commented Aug 29, 2023

I think we should fix the behaviour here so it works as documented.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants