Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allow jsx/tsx with webpack #1046

Merged
merged 2 commits into from
Jan 5, 2024
Merged

Conversation

wattanx
Copy link
Collaborator

@wattanx wattanx commented Jan 5, 2024

πŸ”— Linked issue

Fixes: #17

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

jsx and tsx do not work when typescript: true is set.
I would like to add the isTSX option so that tsx and jsx will also work with webpack.
(I didn't write a test for tsx in nuxt2 because I thought there were few use cases using tsx.)

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@wattanx wattanx requested a review from danielroe January 5, 2024 06:21
@danielroe danielroe merged commit 60358f0 into main Jan 5, 2024
9 checks passed
@danielroe danielroe deleted the fix/allow-jsx-component-with-webpack branch January 5, 2024 07:39
@github-actions github-actions bot mentioned this pull request Jan 5, 2024
@github-actions github-actions bot mentioned this pull request Jan 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

JSX Render Functions in Nuxt 2 with Nuxt Bridge are failing
2 participants