-
-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: type correction for loading
, loadingIndicator
, transpile
#1023
Conversation
* ``` | ||
* @type {Array<string | RegExp | ((ctx: { isClient?: boolean; isServer?: boolean; isDev: boolean }) => string | RegExp | false)>} | ||
*/ | ||
transpile: { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice <3
@@ -254,6 +246,7 @@ export default defineUntypedSchema({ | |||
* configuration. The name can refer to an indicator from [SpinKit](https://tobiasahlin.com/spinkit/) | |||
* or a path to an HTML template of the indicator source code (in this case, all the | |||
* other options will be passed to the template). | |||
* @type {typeof import('../src/types/loading').NuxtOptionsLoadingIndicator | false} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's still missing the type false
isn't it ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have confirmed that setting false
does not cause an error, what do you think is the problem?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here's the current issue I have
And here's the attribute in the node_modules/@nuxt/bridge-schema/dist/index.d.ts
ConfigSchema
interface
/**
* Used to set the default properties of the page transitions.
*
* You can either pass a string (the transition name) or an object with properties to bind to the `<Transition>` component that will wrap your pages.
*
*
* @see [vue@2 documentation](https://v2.vuejs.org/v2/guide/transitions.html)
*
* @see [vue@3 documentation](https://vuejs.org/guide/built-ins/transition-group.html#enter-leave-transitions)
*/
pageTransition: {
[key: string]: any
},
@danielroe I just discovered another type mismatch (currently installing bridge on a old Nuxt 2 app). app: {
head: {
script: [
{ src: `https://polyfill.io/v3/polyfill.min.js?features=${POLYFILL_FEATURES}`, body: true }
]
}
} But I can see in Unhead's documentation that
Shall I open a new issue for this one ? |
π Linked issue
Fixes: #1019
Fixes: #1016
β Type of change
π Description
I will correct the types for
loading
,loadingIndicator
,transpile
in the nuxt.config.I would like to add type tests in a separate PR.
π Checklist