-
Notifications
You must be signed in to change notification settings - Fork 101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: include .d.mts
file for bundler compatibility
#786
fix: include .d.mts
file for bundler compatibility
#786
Conversation
@danielroe Do you know what the status of this is? I'm facing this issue right now with |
I can confirm that your latest changes do solve my issues. :) When you know, can you tell me know which version this'll be going into? |
.d.mts
file for bundler compatibility
.d.mts
file for bundler compatibility.d.mts
file for bundler compatibility
Fix released in v0.34.0. |
Hmm, @danielroe are you sure the change went out? Looks like the change may have got lost in the merge. This is what I was expecting to see: |
In the end we create an extra declaration file owing to an issue with siroc. Does it not work? |
Nope, I get the following error when using
But we're planning on starting the migration to Vue 3/Nuxt 3 in a few weeks so I don't think it's a high priority issue for us. |
@BryceBarbara Can you provide a reproduction? I can easily revert to a previous version of this PR if I can confirm the issue. This looks right to me: https://arethetypeswrong.github.io/?p=@nuxtjs/[email protected] |
I can't recreate any more due to losing access to the source code in question but I appreciate your follow up! My guess is that the warning the types tool is referring to Also, I love that arethetypeswrong tool! I wish I knew about it sooner! |
Let me know if you or anyone else still has a problem (with a minimal reproduction) and I will very happily iterate on this. |
As mentioned in #785 this is PR that fixes exports for compatibility with moduleResolution: bundeler.
Let me know if there is anything to add.
closes #785