Added support for logging out without an API endpoint #124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a fix for https://nuxtjs.cmty.io/nuxt-community/auth-module/issues/c90 Setting the `logout` strategy to `false` will effectively mean that logout does nothing (it simple returns). However, when you have a stateless API, and no need to call a logout endpoint, you still want the user to be logged out in the browser (token removed, session reset, that sort of stuff). This change handles that by not returning if the logout option is falsy, but instead only skipping over the networking part. I think this is the behaviour people would expect when they set logout to `false`.
pi0
approved these changes
Apr 6, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a fix for
https://nuxtjs.cmty.io/nuxt-community/auth-module/issues/c90
Setting the
logoutstrategy tofalsewill effectively mean thatlogout does nothing (it simple returns).
However, when you have a stateless API, and no need to call
a logout endpoint, you still want the user to be logged out
in the browser (token removed, session reset, that sort of stuff).
This change handles that by not returning if the logout option
is falsy, but instead only skipping over the networking part.
I think this is the behaviour people would expect when they set
logout to
false.